[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG REPORT] soft_reset (kexec/kdump) does not work with mainline xen
- To: Dongli Zhang <dongli.zhang@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 25 Feb 2022 08:15:55 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6psnJpzd9Jc7hs0y3CIABWWV9FExx0g5VblraM77pcE=; b=h3xdHdx7L0uc5Vn7SAWrGBafPIW7DAQuVY6isFzPzGLc4koh1ITbcOcCgx12c/RKG3l97ezWJQF1S9JeZejd03wpa7diAKD3ScptdbmL9Qwz8jj9+Js0OLjdvJha14OOsmkEvevI7LnkTf51J1Tv7u2t4QbRVK1pnzJhWkiNYfbSb1gyjvh8DKXQfp/fGdsYIdemLIJrSyny1S/c289rOu8XsTP3VuQKt3FYdtZqa6EwBRwrJdZyIWy7FcEzgy15gylT8lQ+2DnnMkVMDA6lxXGHuMhi36Zg267+8joxPuz94xhUK+44d0L0rj73gWwdXypM3WZYfi7HoSToM7S1Nw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyOa4jennSvY6JH7GL9DMFYCMUPYylXOAHiXQPxK+EdzFTdQNjKmPkYduGr3+JC9l82lxu2T/vExBeZnVndoPcd5xCIZfJNBPaZWOyk5jN8QAakgBCrE3kQ2K1uJn1N0nUcScS/dPvqk5zYV10mXMm3PcEO3//rWKVBTMbcD6McHPfVzlyUp0caXDVLuP2omre97v88LoMLdF26my5PY3G4pNkHdjg4o+72XHl4/rB/DxlcvoNIPn8NVabevVGn45MS+nGF7GNeZLsbeCsAZsrs84LYXVTVhD0Zvn392uhsP9SkVKoDj6sKM4uQTHy/nKAR/9RSpTJF34vj/l4Ujzg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 25 Feb 2022 07:16:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.02.2022 23:27, Dongli Zhang wrote:
> Hello,
>
> This is to report that the soft_reset (kexec/kdump) has not been working for
> me
> since long time ago.
>
> I have tested again with the most recent mainline xen and the most recent
> mainline kernel.
>
> While it works with my old xen version, it does not work with mainline xen.
>
>
> This is the log of my HVM guest.
>
> Waiting for domain test-vm (domid 1) to die [pid 1265]
> Domain 1 has shut down, reason code 5 0x5
> Action for shutdown reason code 5 is soft-reset
> Done. Rebooting now
> xc: error: Failed to set d1's policy (err leaf 0xffffffff, subleaf
> 0xffffffff, msr 0xffffffff) (17 = File exists): Internal error
I don't suppose you tried you track down the origin of this EEXIST? I think
it's pretty obvious, as in the handling of XEN_DOMCTL_set_cpu_policy we have
if ( d->creation_finished )
ret = -EEXIST; /* No changing once the domain is running. */
Question is how to address it: One approach could be to clear
d->creation_finished in domain_soft_reset(). But I think it would be more
clean if the tool stack avoided trying to set the CPUID policy (again) on
the guest when it soft-resets, as it's still the same guest after all.
Cc-ing Andrew and Anthony for possible thoughts.
Jan
|
