[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
- To: Christian Lindig <christian.lindig@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 25 Feb 2022 16:28:43 +0000
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
- Delivery-date: Fri, 25 Feb 2022 16:29:29 +0000
- Ironport-data: A9a23:NeSUDatUmu431461TjMrfJkWvefnVFNeMUV32f8akzHdYApBsoF/q tZmKTqBbqveZWD0L4olbIy0/BgAvceDzIVgGQJoqSlnRCpB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1nX5 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8gB67lkdoRdSIAGjskNq9JoZbGfEWg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWQzMEiYPU0fUrsRIIMXjtikmkOkTzMGuGzIuZBo6HnLyRMkhdABN/KKI4fXFK25hH2wu Wbu72n/RBYAO7S3xTOb/1q2i+TInCe9X5gdfJWo+/gvjFCNy2g7DBwNSUD9sfS/klS5Wd9UN woT4CVGkEQp3BX1FJ+nBUT++SPa+E5HMzZNLwEkwAi0yYPd3Qq/PTANVGRKatN/nc5reCN/g zdlgOjVLTBotbSUT1eU+bGVsS6+NEApEIMSWcMXZVBbuoe++enfmjqKF48+S/Dt0rUZDBmtm 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU J04dy62trFm4XalznHlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hYJGC1O ROO4VsJvPe/2UdGi4ctMupd7OxwkMDd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2 40EbJXiJtQ2eLCWXxQ7BqZIdQFadSVgXMuuwyGVH8baSjdb9KgaI6e56dscl0ZNxvk9ejvgl p1lZnJl9Q==
- Ironport-hdrordr: A9a23:5Xf+E62EAV186fiuMg/9zwqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Feb 25, 2022 at 03:30:59PM +0000, Christian Lindig wrote:
>
>
> > On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
> >
> > This patch fix ".ocamldep.make" rule by always spelling the variable
> > $(OCAML_TOPLEVEL).
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > ---
> >
> > Notes:
> > v2:
> > - new patch
> >
> > tools/ocaml/libs/eventchn/Makefile | 8 ++++----
> > tools/ocaml/libs/mmap/Makefile | 8 ++++----
> > tools/ocaml/libs/xb/Makefile | 8 ++++----
> > tools/ocaml/libs/xc/Makefile | 8 ++++----
> > tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
> > tools/ocaml/libs/xl/Makefile | 8 ++++----
> > tools/ocaml/libs/xs/Makefile | 8 ++++----
> > tools/ocaml/Makefile.rules | 2 +-
>
> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
>
> I am fine with this but in general think that the OCaml part should be built
> using Dune (but invoked from Make), which is now the standard tool to build
> OCaml projects and is simple, fast, and accurate. Edwin maintains such a
> build for all development work on the OCaml side but it is not upstreamed.
ocaml-dune doesn't seems to be available on debian oldstable. So I don't
think we can use it for now.
But thanks for pointing that out.
--
Anthony PERARD
|
