[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 14/19] xen/arm: add Persistent Map (PMAP) infrastructure
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Feb 2022 11:10:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhV0rwXLk/9UoG+nLDskczyhy8V7ZE8R4qS2txZL3Ic=; b=bnBtOYTO9sL/TPfHL+YQYe316KMFkMqV+4hBsjF9dQ5kR/9srRpBn0N0N7M9SzXKPAFtFRSCJkVJLo951aOmUjXIBRM7d7ogdK+VhU/BmCmsyCKDZb8zVNd9QJnhMkeIv+X/YKDLLiR+C1YQsdU6NTwVKPEmbDvKgAGveq1uy/djtAHYI/Q+3X0uMNAmgSR7g6dj5T02EEKnGTAEYLHR6DUvzVV4UT07OMIxGkZwdd7UjORi6O4mkXmXFcfwiQCkdDPclL2ereCsU/DHCPsiwALOUDwpSSMf8RR44QxBwnT15GgB4MyAN1KPA/vFMyayGCISRSX0RJMjQ5tQfR8eOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=geoqYE68m9FwhIL/dRcriJA79w4P6rQVlCGap9M/fUYM4T88VilbsoKIngjWFk4fpmNpX2ubxGvk6GBUcgLTvAamMlQwbFxLMIVdEIP7GzMTuZZqaVq4aLkCd6239PFxOCLCCgh3+olM3sRF3en4nMW+eQEmh/vOTWSNcQOi49eKZaUxdwon3UBDdj7PaDem2q5IeDKtqAlcDniNs5Yp6GiF620pdzLa54i0VbndHM4qflT5PSsjPJxj2e7y8C0RHATNYdwr4u07YgTOCwz7FPq/R+Fm3MWUx3cmyTJ5HrGcEnzW5EJ9U86YwnglcaG+l+arapiNQGsvdoXB7ZYI8w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wei.liu2@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Hongyan Xia <hongyxia@xxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 28 Feb 2022 10:10:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.02.2022 10:55, Julien Grall wrote:
> On 22/02/2022 15:22, Jan Beulich wrote:
>> On 21.02.2022 11:22, Julien Grall wrote:
>>> + /*
>>> + * We cannot use set_fixmap() here. We use PMAP when there is no
>>> direct map,
>>> + * so map_pages_to_xen() called by set_fixmap() needs to map pages on
>>> + * demand, which then calls pmap() again, resulting in a loop. Modify
>>> the
>>> + * PTEs directly instead. The same is true for pmap_unmap().
>>> + */
>>> + arch_pmap_map(slot, mfn);
>>
>> I'm less certain here, but like above I'm under the impression
>> that this comment may no longer be accurate.
>
> This comment is still accurate for Arm. I also expect it to be accurate
> for all architectures because set_fixmap() is likely going to be
> implemented with generic PT helpers.
>
> So I think it makes sense to keep it in common code. This explains why
> we are calling arch_pmap_map() rather than set_fixmap() directly.
I guess I was rather after "when there is no direct map" alluding to the
planned removal of it on x86.
Jan
|