[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two)
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 1 Mar 2022 14:57:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F0o4CclDFBM/vYkNxNk52Pf4Zvl4PzYaQgACplhV06M=; b=dxkHk8Iw+v00Y75gKIUNUsoaXVzIld7DmMqb7lqTs3Z8nxdn1gNGTbHI8L0HKhSAeRfu/Um/R//jm/f8QYg7HWhVy1fz+eeCJmy6dD5YxDkIWM/B5qqLNq+FWlih5yhjZvoC/E0Dl5mn7shyLK3U6M76HQe1BVCPMhISUYXzox0hFwuPeI90DUtwQvFiGPw8uBWIBR86C5ynBHM629vN39WlIP6DukJ6YKcRDDi17bpfUbkP2iVLwhRo6vMzwmdns0Fiz17MpSCIzhH2Y6hyvB0CAHudMIKJnmcaalOmOQUe+33dXpfLfI+hsSmm25P2SjdprrSFm4bmOXeOy6WStA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgLcxz8yjKpe3EYkBQTvATaz/kA3ly6E/hNbIkO50uLrxjhlOutnIG+BDud5H1eD4cCpBMgrKLtcG8g5kgGUuB+LTkQl96FNY0DYL0XTGgEjWKzNrYOf5KgeAvGfVcmfktr3jHFFApjwPQNPO0yfbT4ZldbWB6otRch3YDw7MTW2VVsRbX4qx1gzNSVOElPWfBxdR4n9vdY73W6qwzr6vT3u0TIFCkpnJOQPT5L/DEUDKk32U840Pxm4hMqitdUiFe3ud+9PuRp5t7lGu8Fj/BjUaBjOKsgrHkFlbQ6gIwaRnbwZPzosZbdhD9gRZC9miiQYwPQfZ70mZ69bQ08LnA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:58:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYLIsQ1/MnnQEZyUi9t6TTCfZIq6yqoFuA
- Thread-topic: [PATCH] xen/arm32: head: Mark the end of subroutines with ENDPROC (take two)
Hi Julien,
> On 28 Feb 2022, at 10:07, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Commit 2ac705a59ef5 ("xen/arm32: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
>
> Unfortunately, I missed fail(), switch_ttbr(), init_uart() and
> __lookup_processor_type(). Add ENDPROC for the benefits of
> static analysis tools and the reader.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/arm32/head.S | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index b1d209ea2842..13cfc837d39c 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -661,6 +661,7 @@ ENDPROC(launch)
> fail: PRINT("- Boot failed -\r\n")
> 1: wfe
> b 1b
> +ENDPROC(fail)
>
> GLOBAL(_end_boot)
>
> @@ -694,6 +695,7 @@ ENTRY(switch_ttbr)
> isb
>
> mov pc, lr
> +ENDPROC(switch_ttbr)
>
> #ifdef CONFIG_EARLY_PRINTK
> /*
> @@ -711,6 +713,7 @@ init_uart:
> #endif
> PRINT("- UART enabled -\r\n")
> mov pc, lr
> +ENDPROC(init_uart)
>
> /*
> * Print early debug messages.
> @@ -798,6 +801,7 @@ __lookup_processor_type:
> mov r1, #0
> 2:
> mov pc, lr
> +ENDPROC(__lookup_processor_type)
>
> /*
> * Local variables:
> --
> 2.32.0
>
|
