| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb
 
To: Stefano Stabellini <sstabellini@xxxxxxxxxx>,        Christoph Hellwig <hch@xxxxxx>From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>Date: Wed, 2 Mar 2022 08:17:52 -0500Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=noneArc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5AZWSbOc0KTtdyh9+8qxRvai+pDBFNH4HZ/HB6BAL8=; b=isWTqH+pDWOyRcp9oL1Q4s017qgkkEdl5k5h5h5y/N+DwjuwNTCbCrnHsi/4aQPGJBWCFsijuwBy2BQZx48TLJOgYtMDRQeDevRTAwN9N4MX5SzlLlABdXDI6j9Q7GwUR7pq0SYkFTOZJpAl1HWBqkqz+Y6D8+TlnfCIcfoMgi2dSjQ3KY+qG8y5ZMBYXBPLRsLhHT59rLOnnlfo5AwD3HOCwQ6DeAItv64sJIHMAQ829dkuheLcqscauwgkNcSGPCS99e1OI1z9LyXhTVDrNxs9Qb7P8eOKMJh5C91ho2HgbXVtd6pIYUGVDfx4DT3oyIWAY21ipEY/9nVJU3FEaA==Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqAhL5bqplMBWx1mtMp+PbbkOInJYc9I0Mu6ioVV0Rb11tGzAAmQt4tOOdBrtFfVXdNdvN0cndLJHXYlmOpdce72qRgfSkX9OFWpv3fbaDcE7EjjOqalzGWezrevkEj6jEdA+nFuyumWvEag7w2iiopuGaUzHVuHE/gonC14vOTi12uvT+SrmGIeInDBn8zlwQUXgZ3dfGdk4pH34jBDmmV6Xah0kxC//zUA9peoECc68ze4zGXCFgWsPPYRdgTsb8G6Krf6fEVFArsbzMaueHBcbZQT7AUa3W9trUj5LlJp+VSWheX1A4UzGR7SN9lojaTEg2uC9FN7NqzC8gYSUA==Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx,        Anshuman Khandual <anshuman.khandual@xxxxxxx>,        Tom Lendacky <thomas.lendacky@xxxxxxx>,        Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>,        Juergen Gross <jgross@xxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>,        David Woodhouse <dwmw2@xxxxxxxxxxxxx>,        Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>,        Robin Murphy <robin.murphy@xxxxxxx>,        linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx,        linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx,        linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx,        linux-s390@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx,        tboot-devel@xxxxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxxDelivery-date: Wed, 02 Mar 2022 13:18:52 +0000List-id: Xen developer discussion <xen-devel.lists.xenproject.org> 
 
On 3/2/22 8:15 AM, Boris Ostrovsky wrote:
 
On 3/1/22 9:55 PM, Stefano Stabellini wrote:
 
On Tue, 1 Mar 2022, Christoph Hellwig wrote:
 
Allow to pass a remap argument to the swiotlb initialization functions
to handle the Xen/x86 remap case.  ARM/ARM64 never did any remapping
from xen_swiotlb_fixup, so we don't even need that quirk.
 
 
Aside from that the rest looks OK. Also, you can add my:
Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
 
Not for me, I fail to boot with
[   52.202000] bnxt_en 0000:31:00.0: swiotlb buffer is full (sz: 256 bytes), 
total 0 (slots), used 0 (slots)
(this is iscsi root so I need the NIC).
I bisected it to "x86: remove the IOMMU table infrastructure" but haven't 
actually looked at the code yet.
 
Again, this is as dom0. Baremetal is fine.
-boris
 
 |