[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32
- To: Dongli Zhang <dongli.zhang@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 2 Mar 2022 19:20:38 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NFC70BiF9kXdxPXApLojElkpvB7Fub06OPV7fhkw2GY=; b=KmC7IVTs1y2qALM9OwiyU0q/qYdMtaiWCkM6VzA5BqIdC2+7RBm65/pVGp0hi/RM9Py2DZbhJTZClJraQTfVlzx7xmQnBWT8QXoA17daAJoBTzUdj0C2mfLztIf3sbXlH5zL6YrF7EocgDEcr0QX4Fg+d0N/9vCzdYmmGauQRsrH1Cd4B16+fSB9DCjELs0QsKofI5MQgBqvwfcNLKtvYTvDMRYENFr5hFFFXiaDD+3wmeF9TnGnIrnQba+Ut2TBrdxLHLritZtbhWdZER0sOK14Vy0duqYj2ZlwWrLfskGOelfIOSAdze9GbpebCx87MKdtEkhCeiT1BRExXdoKhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ATJ3mRXWSVjXLKWkiYE0eHj8cr5Mfn0UHMNuEDQHph/uhaxJnbh+LZaxt5OrsQOAh6iVU4htyU1103jmeWAKeKsfjb8Bn4ZUP7T4AiWbeihfKZJIoji1k2SVVZmiq4uvGtBIHr0iHeoQVR3lwx13nNMyQJGyqcQcjxQCjZj6LUxXDeNhJdvtCQwHUCD/hwuPMCp7oVkeF37tuVrYl5bNCc/sj9BwNCsIrz9RW6ZTyLdTFMiXaNk6IZT5O1oE/FlouvzrNeAnxiq68gz1dW3a0flQ04RcN4g4yS13kBJEbD/DTSa/6feYO5Bs9hV/iKZ6DUZ6CAISSZnvHCrYzJLQqQ==
- Cc: linux-kernel@xxxxxxxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, joe.jin@xxxxxxxxxx
- Delivery-date: Thu, 03 Mar 2022 00:21:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 3/2/22 11:40 AM, Dongli Zhang wrote:
void __init xen_hvm_init_time_ops(void)
{
+ static bool hvm_time_initialized;
+
+ if (hvm_time_initialized)
+ return;
+
/*
* vector callback is needed otherwise we cannot receive interrupts
* on cpu > 0 and at this point we don't know how many cpus are
* available.
*/
if (!xen_have_vector_callback)
- return;
+ goto exit;
Why not just return? Do we expect the value of xen_have_vector_callback to
change?
-boris
if (!xen_feature(XENFEAT_hvm_safe_pvclock)) {
pr_info("Xen doesn't support pvclock on HVM, disable pv timer");
+ goto exit;
+ }
+
+ /*
+ * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'.
+ * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest
+ * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access
+ * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic.
+ *
+ * The xen_hvm_init_time_ops() should be called again later after
+ * __this_cpu_read(xen_vcpu) is available.
+ */
+ if (!__this_cpu_read(xen_vcpu)) {
+ pr_info("Delay xen_init_time_common() as kernel is running on
vcpu=%d\n",
+ xen_vcpu_nr(0));
return;
}
@@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void)
x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents;
x86_platform.set_wallclock = xen_set_wallclock;
+
+exit:
+ hvm_time_initialized = true;
}
#endif
|
