[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 24/30] build: grab common EFI source files in arch specific dir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 3 Mar 2022 11:37:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8E3RCyIW0RgEyy9HViPcUuRfEwybAzF6dZQbN9GiutQ=; b=HwEWkWra9DxPYwAMY+g81RKt+IQcd8pCVFJrG5cvAnR6mLCWdFuitJ3Su3rJxH8vQkJBtH7AQcvle6xSlNPUicmsyR79b4pBOV5+fPdyxy+jracvf7WiqUw8yowLvDke0TqzOFSozBRiadqAJ0/KkkNHveuWjOhtvPERkArXiVjXBA6jVr9Iw1Uoih6gh/aDbgzwL7EC4esYUaFeS//DkCARi8E0wlvpQOF5YvQmPGmkCs5jqYhj9sH3wtvYqY2fhMfyoYWhMyuQczf7/n3xfH4wgsY39JGzpFVDMfGZcVnrplLmm88VqS5zGBRCnSjZWnCC66IWefxX9ZV/Yms+vg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huBjHBx/0wMZDUxV/GWEOSgz4BKn/qJDFEmQLZfHYHLa4A+wARSi8U3lULGG2tMHMwpw646pVx+O/QO/yibi+Wpjk289yPaW0vIzB6mS1wB8/lbATZA28NTTdh34ZNM5VhXxTOF5Z12YyraKcDLoMLswpnjKK5HE9PPDfrTIroOuSuCSrtkUfDoDC0lzVac/LDf0yHMCYe6+9If8MgWxuTsn8GSRqkZwmHlrnDjxdAMoGFF2awxI3hhhqlThLosASFptNJjhGkTqXkIdp3Mk0bEdMJGwyJaLlAPy7S+2UB3ifbhWDJbhaHh196M8uKtrg8kfU5PsilSSm4gMjBhuhw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 03 Mar 2022 10:37:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.01.2022 12:00, Anthony PERARD wrote:
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -77,8 +77,9 @@ obj-$(CONFIG_COMPAT) += x86_64/platform_hypercall.o
> obj-y += sysctl.o
> endif
>
> -# Allows "clean" to descend into boot/
> +# Allows "clean" to descend
> subdir- += boot
> +subdir- += efi
No similar addition is needed for Arm?
> --- /dev/null
> +++ b/xen/common/efi/efi-common.mk
> @@ -0,0 +1,15 @@
> +EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o
> +EFIOBJ-$(CONFIG_COMPAT) += compat.o
> +
> +CFLAGS-y += -fshort-wchar
> +CFLAGS-y += -iquote $(srctree)/common/efi
> +
> +# Part of the command line transforms $(obj) in to a relative reverted path.
> +# e.g.: It transforms "dir/foo/bar" into successively
> +# "dir foo bar", ".. .. ..", "../../.."
> +$(obj)/%.c: $(srctree)/common/efi/%.c FORCE
> + $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /,
> ,$(obj))))/common/efi/$(<F) $@
What is the "reverted" about in the comment? Also (nit) I think you want
s/in to/into/.
Jan
|
