[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/36] xen/arm: add coloring data to domains
- To: Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Mar 2022 08:22:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WzFDXxWDK2sJ2o/S5nZgsygIWlIUOI+W05Jh37KClns=; b=BfFEpTsiERuq99e3QNAfVvGLSLzNPiXcAe3AYLsgJT2M4GufXohrLV7grDNkXyMqhTgmgbzRVgkrTLG3cV2rIO6dX82NTEWhifS9HIUa97lFGdlv0lh1SCS9AWl7zEWzC6FnkxotoTZxW42tjgvo/aCg1v52F6emciEfVHwzfbeWtTo4bDIWuTRyx1kULsFpnWZpyxh1zNEa833P6EUbnxiBSmoAnp9tjqu7FLhpgc12usGX4WOMwn1LZq1sfx9L2O9oI49i7da9eG7PhM7NMl+zzHZvxhitV28FJouW3pA5BqANGY26ncWxXyByH+dOZugsvGVP6EDP1Y7IiX9ikA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwayfVxW3dkXh0gSz/D4ubTMGQRRVQKvkmQV/JXzSeRLGSjlS93WgeckRLhmGm+KtdtiWfCgHRBex628WkYjhhyqPtSRreUrZXqsIR4dkkI0oomxWWYjJDwqcxeBLYJRSUYY0ynZ5OdCOZoMpQ63QV57sQt0kmdHzggTimsgkaseUegx3WgaFT7Fa0JXtrtzXgEUJaSypUz1irQH6n/+0+I49ejbhUg+xMBsY/R03A2LnQMTZox6pUlN1fATwXlviz3wLIujSh8o8StOvfmTbcE5upbSSnxKVuSTnkbliHs4tA8hVJOQy8arSFTph7H8+wZ5TRMdE/wo6Ymsw+f13A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxx>, Andrea Bastoni <andrea.bastoni@xxxxxxxxxxxxxxx>, Luca Miccio <lucmiccio@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Mar 2022 07:23:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.03.2022 18:46, Marco Solieri wrote:
> From: Luca Miccio <lucmiccio@xxxxxxxxx>
>
> We want to be able to associate an assignment of cache colors to each
> domain. Add a configurable-length array containing a set of color
> indices in the domain data.
>
> Signed-off-by: Luca Miccio <lucmiccio@xxxxxxxxx>
> Signed-off-by: Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>
> ---
> xen/include/xen/sched.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 10ea969c7a..bfbe72b3ea 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -388,6 +388,10 @@ struct domain
> atomic_t shr_pages; /* shared pages */
> atomic_t paged_pages; /* paged-out pages */
>
> + /* Coloring. */
> + uint32_t *colors;
> + uint32_t max_colors;
You will want to justify why this needs to live in struct domain, and
not in struct arch_domain (as the title would suggest). You will also
want to check whether uint32_t is actually appropriate to use here -
see ./CODING_STYLE. Finally, a comment this short (and hence ambiguous)
isn't worthwhile to have, imo. It (as well as the title) doesn't even
include the word "cache".
Jan
|
