[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/36] xen/include: define hypercall parameter for coloring
- To: Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Mar 2022 08:31:56 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9MzOaZCQ4KsNhbKy2oDZ8s6PNB0BqvBTtfujc6kJ9nQ=; b=eGKbGZdfSzwFcHw6AuT79FJRDf9Vao7Jt7WrOTTszyNS8IOXoZDgCTXCTsq2MQABpzGcVYYyhxnnGAfyRY8EeA6Mxj9y5k7R//32gOaoGj3v16Y+dqrLC9gBcty1sxPHn2t4nsbc6QH5Uhy/Io4/9lcF+OsWKeKHLJn5RDN8rxf4MOyZuM8e6P7Pw+1ZBx+EKAuXrsiTC1lgcGVrxgx6lm2smHj0AmgjK9jMLvdtXiTmFBU7uSbb6nzhi6jvXmVsC4OVk/wN7ntWXMx1ptcBbtoGr7ylkO8hUNNWM3Gqa650mzm+5mQFaIRBlv0jViMWUk6ToS1q2A1JlI0oOZ2juw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT35G+w8uJ9OnQ3QH5e5ocNjTqu0Xpftfdmgq7iIS2ZIVliKJ61fKaijYi+wk8LFC7RTZar2ijHLvW/BDVUwg9dv8nV7VEoWEWpMJeJn9fK76FB99VIJ95bLdxVIkve1jHRlj40Rw08JgFUQmSdV+NqDxghAu6F4WDLB/Qm0Lh7sPKl25b0SZ+UkVHXCY60ZxXKW9ywrBZFcDXG7Arn9RsJKfcExRdxrOqJeJ2R09Y3mLttFrJYS6+4r4yNO09CZ53VfCLWSoOwtujHQgQQw3sstW5BKb0XTR6oNATA4TgVh6JaoU3B0cVU538Uv5tG50reQimeeaVvoNryGTvypSA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxx>, Andrea Bastoni <andrea.bastoni@xxxxxxxxxxxxxxx>, Luca Miccio <lucmiccio@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Mar 2022 07:32:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.03.2022 18:46, Marco Solieri wrote:
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -303,6 +303,12 @@ struct vcpu_guest_context {
> typedef struct vcpu_guest_context vcpu_guest_context_t;
> DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>
> +#define MAX_COLORS_CELLS 4
> +struct color_guest_config {
> + uint32_t max_colors;
> + uint32_t colors[MAX_COLORS_CELLS];
> +};
> +
> /*
> * struct xen_arch_domainconfig's ABI is covered by
> * XEN_DOMCTL_INTERFACE_VERSION.
> @@ -335,6 +341,8 @@ struct xen_arch_domainconfig {
> *
> */
> uint32_t clock_frequency;
> + /* IN */
> + struct color_guest_config colors;
> };
> #endif /* __XEN__ || __XEN_TOOLS__ */
>
Please no new additions to the public interface without proper XEN_ / xen_
name prefixes on anything going in some global name space. (Personally I
also wonder whether a separate struct is warranted, but I'm not a
maintainer here, so I've got little say.)
Jan
|