[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 28/36] xen/arm: introduce xen_map_text_rw


  • To: Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 7 Mar 2022 08:39:03 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+A6exbRyakH8VBMY1Lm+YRC0U2Pe4ZMpXQkghKUaZ8c=; b=HNTbySm3OBoCL6J2MoOF2qs/kSIyNA/EdqZJMSNtpJf1/yqxEHMgcYcmpZzCrCg3D0C0kDnrM0JR5mmqnWcMMqjJY+1ZNy7m+88vbp0r9ydRs5AiPby6YmibIymxCa+zuh4H67eqIcDW5GYCmF9VaQ7C4UxHmn8PzZxEu+sEHaHbhvEd66sY8MUVvDD5tXzYlA+exTT4h4JzBghOF1D7dLpztvWcmwhVmTGJc7FskiU3dcKvt2kYv7ntnmSrJJ+VIFbuC5/Km8eZmDcLubLS/nSHRhDGdW+BxPvalENGwiDk0buJpOn8v08cueH+iH5UqE/kaWYngHqgK6f1YzkfPQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hq1qm8mTPxZ9yeWl0+QktU9my/TORkbo/VINNPh6VPvikpWUkX4Xw0Y6bo940L7+K1rDbfhmtqqHxXtneh8Dfz6he+9cYSBYoDj6GCf011vhsCiNKdCeqoUQRWRXwqQW/OPnUYNcE75HtZEDNdcHhYGpXe73KHqQrk/F9R0Z+BqUMuwBL83CPt9ME2TvsoFKvec8UBBcVFWOb0l3VOU/RUPyFuvPPtDXOEUC6ZgS7q9Uzd/Qg29rlGOasBhKOctJg/dqp4p+Bcge6cPFE49i/xU3wGI3lXdKm60jlETAl6v3s0YRTWJucq1xPczlw8mpTf3Q69Dkw/by7sRN/LI7Dw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxx>, Andrea Bastoni <andrea.bastoni@xxxxxxxxxxxxxxx>, Luca Miccio <lucmiccio@xxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 07 Mar 2022 07:39:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.03.2022 18:46, Marco Solieri wrote:
> From: Luca Miccio <lucmiccio@xxxxxxxxx>
> 
> Introduce two new arm specific functions to temporarily map/unmap the
> Xen text read-write (the Xen text is mapped read-only by default by
> setup_pagetables): xen_map_text_rw and xen_unmap_text_rw.
> 
> There is only one caller in the alternative framework.
> 
> The non-colored implementation simply uses __vmap to do the mapping. In
> other words, there are no changes to the non-colored case.
> 
> The colored implementation calculates Xen text physical addresses
> appropriately, according to the coloring configuration.
> 
> Export vm_alloc because it is needed by the colored implementation of
> xen_map_text_rw.

I'm afraid I view vm_alloc() as strictly an internal function to
vmap.c. Even livepatching infrastructure has got away without making
it non-static.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.