[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/13] xen: drop hypercall function tables


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 8 Mar 2022 09:34:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFQud19bU5SI+K0oYr86ExH4b1i7NXdnwoCxsRWm00w=; b=lS1Hz6qigDr9VU6IxVHurVNEL3Nfz2y6FoHwfvDiXEztjk82Nk5+MeKg4Ej6RR0ntSa6ILXlqbtKePEDGU5MdImUtT+ASS5WRBUuH4s3jPz8oThXVMHgOR2lDzxE5oYFABk6SymVggWi+9JAMFeqOmLewshJnk5i/v7pqfw50XgDQGm9RHSrrlDQZxAAbn8hzVM1rDyVUufibr+ySriaFf/S9Ds+9/Nv8bkXNCRe4YBOWw/5JBgZoC6tEaSRLMzapdV+8dQEuTdal4TGGT9WgxmxrS/JovG1sYTIV25YyHthfQZFrRFp2Q5D4tJPJMSXXRNLS2dl9VN+l4C+32h7Pg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nax93LHza/Ni4W+PR5+uFsaVQ7BDiECIq5tZ9313hhY41uqf7L1DT54vhACx0wFzCnUnPRJEWDSuu2UfLBixHEwVOFXdoUL/QQjXh+wQwO2SeCsq9c5j+2Mwd7Md0XuYRJ6KXDH1dusP4z0okXYeIxo2DvQihV/gxhpr+Eakk7VTyTU8o9APtmyOsRQQZ6YAjU+9Y17BJqHjRM+wgKOp+WHtnH2Y0F7aLbHQgslTLXxFgcHZeepF9n1qtoUkUqoRLDegKTubt0sAq0eRuHL4v+xvpkigB7a52Cla83OiqLuYHkvMGUiI9l0dMISHubmqJ1ajpXjcZXx567FqwIMpUA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 08 Mar 2022 08:34:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.12.2021 16:55, Juergen Gross wrote:
> In order to avoid indirect function calls on the hypercall path as
> much as possible this series is removing the hypercall function tables
> and is replacing the hypercall handler calls via the function array
> by automatically generated call macros.
> 
> Another by-product of generating the call macros is the automatic
> generating of the hypercall handler prototypes from the same data base
> which is used to generate the macros.
> 
> This has the additional advantage of using type safe calls of the
> handlers and to ensure related handler (e.g. PV and HVM ones) share
> the same prototypes.
> 
> A very brief performance test (parallel build of the Xen hypervisor
> in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
> the performance with the patches applied. The test was performed using
> a PV and a PVH guest.
> 
> Changes in V2:
> - new patches 6, 14, 15
> - patch 7: support hypercall priorities for faster code
> - comments addressed
> 
> Changes in V3:
> - patches 1 and 4 removed as already applied
> - comments addressed
> 
> Juergen Gross (13):
>   xen: move do_vcpu_op() to arch specific code
>   xen: harmonize return types of hypercall handlers
>   xen: don't include asm/hypercall.h from C sources
>   xen: include compat/platform.h from hypercall.h
>   xen: generate hypercall interface related code
>   xen: use generated prototypes for hypercall handlers
>   x86/pv-shim: don't modify hypercall table
>   xen/x86: don't use hypercall table for calling compat hypercalls
>   xen/x86: call hypercall handlers via generated macro
>   xen/arm: call hypercall handlers via generated macro
>   xen/x86: add hypercall performance counters for hvm, correct pv
>   xen: drop calls_to_multicall performance counter
>   tools/xenperf: update hypercall names

As it's pretty certain now that parts of this which didn't go in yet will
need re-basing, I'm going to drop this from my waiting-to-be-acked folder,
expecting a v4 instead.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.