[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/2] livepatch: enable -f{function,data}-sections compiler option


  • To: Julien Grall <julien@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 9 Mar 2022 13:28:38 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1dY8amo89ajKpys5sAOASBo6UmFGefJUev3QWXdCOhg=; b=P/a2ff13qOMtLT337uBu+nChuhNNqbKtQpCLYB5Yrf0UIqGU+EoB2rJoqMeNOBjcAO1Tmpqp/nEbPZBnYbHUNldkrFM+clEnN0JeymMqKx39rRxw320NXQG0ymnmYJG5ksCM/EBHhIzcmuC3bgh9RYHeYCh7qosU9S4yW4y5ZoIoFTFAtpzH6DvsKZtFmpb3xzitHLIr8nvpsDJhGInkLdBl7a0XMUF9Uad1FBQSwBKwEPu/DJhOrsMLtNv9Az3rjQmxkUfKPYKsQRygxhNrB6Cn//PMQ2SopIq5WHhKbmE7NP7l3IUn6qvnwpanAL+adlS7v8QXmZ/XOXnAtKWgWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=em2rBtJuvG44AIN4t+W8ZwnymOynFu4DKXWimma7nTQUqQrQU7nPGr64GQbZhMGvmBBpu4eXujgHSAcO7mV638UDeiP1ziBRdo1MmtfBJZcQU/j8B7pAA/FetInmfq9dhWHoALdqEKuiNDcqQi4K040jCRh5bUQN+Z8Uf4tutVksmxbA0KiIQKoIybSXfdVLT+gXlOyR/PgB7XjvygdANLAGyPo9qOtba2E2AmyfGzdsGZ79WIWGytWBNnTToyCsPjn8hvvPahnvSK31H9E8AS3aMAP8kXZbLFptVrO7Pbkh7lUaO9HlNH8Xlk0psMMmorZpUD6byg9Ex4OfoO/Cyw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Mar 2022 12:29:07 +0000
  • Ironport-data: A9a23:0yf62qxhybXGf+RSxtl6t+fDxirEfRIJ4+MujC+fZmUNrF6WrkVTy WsaC2mDOP2MM2Hzed5/btnn9E9TsZbUyII3HAJppSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NYz2YnhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplspDpCl4CM/z2h+1ef0F/CXguY4NL0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J0eRamEP pFxhTxHKzPDZxR1HHYsV5MRo9iEikn/cyRXpwfAzUYwyzeKl1EguFT3C/LrfdiNSdRQj1yvj GvM9GTkATkXLNWajzGC9xqEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRokSzQc5FI koYvC8nt7Ev9VeDR8P4GRa/pRasvAMYWtdWO/037keK0KW8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kOYgnnF4g5VvTv15usRG+2k 2viQDUCa6s7isJSlPyQ8AH9nDvvisDuVFdluCvadzfwhu9mX7KNa4ut4FndyP9PKoeFU1WM1 EQ5d9iiAPMmVs/UynHUKAkZNPTwvqvebmWA6bJ6N8R5r1yQF2ifkZe8Cd2UDGNgKY46dDDge yc/UisBtcYIbBNGgUKaCr9d6vjGL4C9TbwJtdiON7Kih6SdkifdokmCgmbKgwjQfLAEy/1XB HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8ylkEr7i+rCOCLLIVvgDLdoRrpphE9jiF+Jm +uzyuPQk0kPOAEASnK/HXEvwaAiciFgWMGeRz1/fe+fOAt2cFzN+NeKqY7Nj7dNxvwP/s+Rp ynVchYBlDLX2C2WQS3XOysLQO6+Av5CQYcTYHVE0aCAgCN4P+5CLc43KvMKQFXQ3Lc6nKAuE KVdJZno7zYmYm2vxgnxpKLV9eRKXB+qmRiPL2yiZj0+dIRnXAvH5pnveQ6HycXEJnHfWRcWy 1F46j7mfA==
  • Ironport-hdrordr: A9a23:+5gWwqk0dK+nAM9oWP4Ev2jvRUXpDfPCimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftWjdyRGVxeRZjLcKrAeQfhEWmtQtsZ uINpIOdOEYbmIK/PoSgjPIa+rIqePvmMvD6Ja8vhVQpENRGtpdBm9Ce3im+yZNNXB77PQCZf 2hDp0tnUveRZ1bVLXyOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx mOryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idgrP D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1vDRdXYfMY5slIhZehzW5w4Lp9dnyp 9G2Gqfqt5+EQ7AtD6V3amGazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu UGNrCR2B9vSyLaU5nlhBgu/DT1NU5DXStuA3Jy9/B96gIm0kyQlCAjtY4idnRpzuNId3AL3Z WADk1SrsA8ciYnV9MMOA4/e7rENoXse2O7DIvAGyWvKEk4U0i93qIfpo9FoN2XRA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Mar 08, 2022 at 02:52:55PM +0000, Julien Grall wrote:
> Hi,
> 
> On 08/03/2022 13:49, Roger Pau Monne wrote:
> > Hello,
> > 
> > The content in v3 has been split in two patches, but is still mostly the
> > same. The main difference is that first patch does a bit of cleanup of
> > the build logic now that the header object file doesn't need to be the
> > first one passed to the linker script.
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (2):
> >    xen/build: put image header into a separate section
> >    livepatch: set -f{function,data}-sections compiler option
> 
> For the Arm bits:
> 
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx> # xen/arm

Thanks!

I don't think Acks require a scope tag, as you can only Ack changes to
the code you are a maintainer for?

OTOH a 'Reviewed-by:' tag would indeed need to be limited if it only
means to cover xen/arm bits.

In any case I've added the tag as provided to v4.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.