[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 10 Mar 2022 16:47:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/s5gVJxNwTvaCF1xn5jjrcbwlk1xb0M8vClxfrriSzc=; b=kRDZTFUoNxAmmax/7swcQYdHe+VVQyJ0aorvnf4wtsCmYUtlBzMihjfI1ErIixUkzOegoOetrR+DXtnpFnkHewwdMgYQlPdJ6qWm6B0dM2cQvRyHzxDLqjc8UX2sm2qJHF1vzij6wOpQaTnirOia7VoZhQ/LxUPEWLVHrs9hZSx/E5NPtPa5Uf8pSdh6M/sxWRqlf8f9j24ve12RstsgulCvUMTovhNlyMxSfpFhvSdzaCEmwG5QX56byKQ3CsbohJK360D6WfEDsOHJfPWJo0qg8RAcDd7niyJ7HnYsLliMjDB/ZwebSYHDkiuRmAwVFlUnmZRPKX/OuWqmrXDKbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hmfgrI3zAIr6nZTbJrw4lvyuUi2O0fvLeH5OtgvnNS1ltRAdvRTD6WH2wiwCYF+Btr7e9jmeiwhxuUcdjDw1uRWqeurTHMJVaQj3N16cAy8ZM22iX3mQvr5t/03x+Cun2u7FOhsNSPWFRKKQg7rD5XPboavep6FddPUxUpCtdrznme66nx/N2Ii+uurdsoIocs9/fFV+15HP1MEo4M/jEXxWNglyE4kWQEK2/EQI/fXC0lqHEuXJ2VKbP0Hyda+ZND9x1b781WpobMftFTlOk+xbGwdbD9O8aUibv00UMgItp3ght9QTA693Q5yBC3Py5MYK8WxOv/3upKlpP2Vpew==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Mar 2022 15:47:23 +0000
- Ironport-data: A9a23:5pDsE6gdmWfTaA4uRgtiRnRiX161uBAKZh0ujC45NGQN5FlHY01je htvDGvVO/qCMDHzfd13bdy+o0tTusWHzYI3HQQ//30xRCwb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhWFrV4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVw2GJ2Wg7tFaRVZHQp8bYpe5Jb7L1Hq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiDN pFHMmo3BPjGSzpDYUs8WJ0Pp/mlv13YSWAE8kzNt4NitgA/yyQuieOwYbI5YOeiXt5Jl0yVo mbH+WXRARwAMtGbjz2f/RqEmevnjS79HoUIG9WQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI FBS/TAhxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4FuQg7QiXx6n84gCHB3MFRDpMdNwnssAtQTUgk FSOmrvBByFrsbCTYWKQ8PGTtzzaBMQOBTZcP2leF1JDuoS95tFo5v7Scjp9OPWqqO2vAm6o+ TyLogM815ILkec32YzuqDgrnAmQjpTOSwc04CDeUWSk8h51aeaZWmC41bTIxa0eddjEFzFtq FBBwpHDt75WUflhgQTQGL1lIV2/2xqS3NQwa3ZLFoJpyTmi8mXLkWt4sGAnfxcB3irplFbUj K7vVeF5ucc70JiCN/Yfj2eN5yICl/aI+TPNDKy8Uza2SsItHDJrBQk3DaJq40jjkVI3jYY0M oqBfMCnAB4yUPo7kmrrHrxGieF7mEjSIF8/o7ihn3xLNpLEOBaopUotagPSPojVEovYyOkqz zqvH5TTkEgOOAEPSiLW7ZQSPTg3wYsTXvjLRzhsXrfbeGJOQTh5Y9eImO9JU9E1zsx9y7aTl lngCxAw9bYKrSCeQel8Qis4M+2HsFcWhS9TABHAyn7zgil9O9nztPlDH3b1FJF+nNFeITdPZ 6BtU+2LA+hVSySB/DIYbJLnq5dlegjtjgWLVxdJqhBlJPaMmyShFgfYQzbS
- Ironport-hdrordr: A9a23:w2xcAak/Ok3fhCUBbgcAMQen55fpDfPIimdD5ihNYBxZY6Wkfp +V8sjzhCWatN9OYh0dcLC7WJVpQRvnhPhICK0qTMqftW7dyReVxeBZnPHfKljbehEWmdQtsJ uIH5IObOEYSGIK8voSgzPIY+rIouP3iJxA7N22pxwGIHAIGsNdBkVCe32m+yVNNXh77PECZe OhD6R81l2dkSN9VLXEOpBJZZmJm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTvj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZrA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKffZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv7nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLUU5nghBgu/DWQZAVxIv/fKXJy+PB9kgIm0EyR9nFohfD2xRw7hdcAo5ot3Z WyDk0nrsALciYsV9MOOA4we7rFNoXze2O4DIuzGyWvKEhVAQOEl3bIiI9FkN1CPqZ4i6cPpA ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote:
> On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote:
> > --- a/xen/drivers/char/ns16550.c
> > +++ b/xen/drivers/char/ns16550.c
> > @@ -1221,6 +1221,9 @@ pci_uart_config(struct ns16550 *uart, bool_t
> > skip_amt, unsigned int idx)
> > pci_conf_read8(PCI_SBDF(0, b, d, f),
> > PCI_INTERRUPT_LINE) : 0;
> >
> > + if (uart->irq >= nr_irqs)
> > + uart->irq = 0;
>
> Don't you mean nr_irqs_gsi here? Also (nit) please add the missing blanks
> immediately inside the parentheses.
If we use nr_irqs_gsi we will need to make the check x86 only AFAICT.
Thanks, Roger.
|
