[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] livepatch: fix handling of (some) relocations
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Mar 2022 14:18:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gM44/RyxAiy8lgRoFEq02yNHIu42B9zSNU+FDv9ga3A=; b=bNCZAp5IUveKQNa3Yiq0nKV3EGnRgs7rXvbDFjLlkvYXqkCWrR9nP3RQoShM+wDdzTrGjuxPyOFQ8LSWAF6r/Lzmy/DZtInTk7AQkxMRF1o194fgnLU4r+s+VLyJy5ln5QwMcwmYb7Xy0W6vynxnUGhZ+pA4El6lkCWga/nfoxasOKthGCOJSH3u3PRcFFeUMiAn1GH6ScxeUxqp6X5tiep5+PYsq7XNlWWn2KYVZ8iqssn61bWI4CH8Ve0g6fBe3ih4sFazhTUHduuFkJjNSgl4iG6wNPqXNMKA6B+km0q7mk1Xkmwkfj5nS85xu6xPygXr20C8PZu4dKpTyI5yTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bq39hOAMEjKG9etZKFuYv5BVtbWXJsLodrfRMFyKfSRAtWAMSr/P21YMx9KrohCIJQTQW7Cz5AF94Zi7UDjkicUVy+7X6MgYi69RpKDNahkSJlSA/+jEcNGYrfOmvJMNIHpk5kPfzDUTCV+ynQ9RcNWicqYRvASwJpBH+TiXSRzF9qDCF2OwJuQ2XBsZ6UX1IXQf0GFlzSwMmzxqDH4uvBFzL4e5IRH3INQJmUhHXqvgUyaOhOmv9BwOxAODv/wsqZjm8TJoz8N9mRRnfm12IYMv9CNBLeA9X0El5c751K6paSCGvzwiYtHf3nbRDHhgL/jTaofsT7thdbKvzNeyKA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Mar 2022 13:18:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.03.2022 12:08, Roger Pau Monne wrote:
> I wonder whether it's possible to have unresolved symbols if we only
> ignore non SHF_ALLOC sections, so we could maybe error out earlier if we
> found a symbols that belongs to a non SHF_ALLOC section in
> livepatch_elf_resolve_symbols. The current approach is more conservative
> as we would only report an error if we have unresolved symbols that are
> referenced in relocations.
I think it's better to remain that way. Symbols appearing in non-alloc
sections isn't wrong in any way, as long - as you say - there's no
relocation using them.
Jan
|
