[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] livepatch: avoid relocations referencing ignored section symbols
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Mar 2022 14:26:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1VHIqP1OG/hn4RTwEROFHx0/Ay2wrsKO4nilEryTyvk=; b=NJl0DvgV5dg1wqo8gmv5dek6DNUSXYLGbvonSKCErc2UVoQKex4x4YtbBg+8SDAdI+d6SmBx2jdHY2W112fpb9DSGNW8D3hwBF3BlO+iBsp2C/5TiObVHKNPQ/5QVRNKasYxaYUbR96Ez5qCgea+m3niTvnteCEZ997tsvPZWcvCln7i59fpUNGqykCLq4ARGrTJYt9fk6DXavEhtJd5gUvLc/qxEw3hsU6HsoAGR92QlpR41D06acRPo3SvTxIdocozjAFwD5+Dt8433fw6UiRUxS143a2EM5Zcsc5/M4dz7baIBFv2LkYaUCmmMwHQd2ncrAn2sqUwrcL7QnyW+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YA/th0n1gJpjmATH4rtx4J47ELw/AA6demUaWotwDGNg8VvwDgLekKfsurVMFB2pArXGoA0JuqPjHbSsJthxYn9q7nyLnmBxAggTQM2MSed+7j5EXsd6vR6j+kmYA7+Mau0KaNn0h3Fql6j0U53/gdO0at1JMtiT/Wexhk5nX2JKGZUKad5hZ9t3SDRPEhdLj3VkgtHa59/ZdB82kY7BMkZuSLjIaHg0Eoq1jwd4mbqa1S2sbOp5egxSAuY2MXtiAilcOg7Kg91EW8a34sHNpUeXcINafLAUc8RrfXDWC4luILY9TVNzSpqV8MLyUoOBBj8pWoCevnZA0OykseF+1A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Mar 2022 13:27:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.03.2022 12:08, Roger Pau Monne wrote:
> Track whether symbols belong to ignored sections in order to avoid
> applying relocations referencing those symbols. The address of such
> symbols won't be resolved and thus the relocation will likely fail or
> write garbage to the destination.
>
> Return an error in that case, as leaving unresolved relocations would
> lead to malfunctioning payload code.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one nit (which can likely be addressed while committing):
> --- a/xen/arch/arm/arm32/livepatch.c
> +++ b/xen/arch/arm/arm32/livepatch.c
> @@ -272,6 +272,13 @@ int arch_livepatch_perform(struct livepatch_elf *elf,
> elf->name, symndx);
> return -EINVAL;
> }
> + else if ( elf->sym[symndx].ignored )
> + {
> + printk(XENLOG_ERR LIVEPATCH
> + "%s: Relocation against ignored symbol %s cannot be
> resolved\n",
> + elf->name, elf->sym[symndx].name);
Indentation here (and in the other two instances mirroring this)
is off by one.
Jan
|
