Re: [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers

[Juergen Gross <jgross@xxxxxxxx>]

On 17.03.22 17:47, Jan Beulich wrote:
> On 10.03.2022 08:34, Juergen Gross wrote:
> > Now that the hypercall handlers are all being called directly instead
> > through a function vector, the "cf_check" attribute can be removed.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> > V4:
> > - new patch
> > ---
> >   xen/arch/x86/compat.c               |  6 +++---
> >   xen/arch/x86/cpu/mcheck/mce.c       |  2 +-
> >   xen/arch/x86/cpu/vpmu.c             |  2 +-
> >   xen/arch/x86/domain.c               |  3 +--
> >   xen/arch/x86/hvm/dm.c               |  2 +-
> >   xen/arch/x86/hvm/hvm.c              |  2 +-
> >   xen/arch/x86/hvm/hypercall.c        |  6 +++---
> >   xen/arch/x86/mm.c                   | 12 ++++++------
> >   xen/arch/x86/mm/paging.c            |  2 +-
> >   xen/arch/x86/physdev.c              |  2 +-
> >   xen/arch/x86/platform_hypercall.c   |  2 +-
> >   xen/arch/x86/pv/callback.c          | 16 ++++++++--------
> >   xen/arch/x86/pv/descriptor-tables.c |  8 ++++----
> >   xen/arch/x86/pv/iret.c              |  4 ++--
> >   xen/arch/x86/pv/misc-hypercalls.c   | 10 +++++-----
> >   xen/arch/x86/pv/shim.c              |  4 ++--
> >   xen/arch/x86/x86_64/compat/mm.c     |  2 +-
> >   xen/common/argo.c                   |  4 ++--
> >   xen/common/compat/grant_table.c     |  2 +-
> >   xen/common/compat/kernel.c          |  2 +-
> >   xen/common/compat/memory.c          |  3 +--
> >   xen/common/dm.c                     |  2 +-
> >   xen/common/domain.c                 |  2 +-
> >   xen/common/domctl.c                 |  2 +-
> >   xen/common/event_channel.c          |  2 +-
> >   xen/common/grant_table.c            |  3 +--
> >   xen/common/hypfs.c                  |  2 +-
> >   xen/common/kernel.c                 |  2 +-
> >   xen/common/kexec.c                  |  4 ++--
> >   xen/common/memory.c                 |  2 +-
> >   xen/common/multicall.c              |  3 +--
> >   xen/common/sched/compat.c           |  2 +-
> >   xen/common/sched/core.c             |  4 ++--
> >   xen/common/sysctl.c                 |  2 +-
> >   xen/common/xenoprof.c               |  2 +-
> >   xen/drivers/char/console.c          |  2 +-
> >   xen/scripts/gen_hypercall.awk       |  2 +-
> >   xen/xsm/xsm_core.c                  |  4 ++--
> >   38 files changed, 67 insertions(+), 71 deletions(-)
> But that's only the definitions; for a reason I forget the annotations
> are present also on the declarations (really the "also" applies the
> other way around; perhaps it was that a future gcc will want to warn
> about declaration and definition having gone out of sync).
See the change of xen/scripts/gen_hypercall.awk which is taking care of that.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature