[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen-blkback: remove redundant assignment to variable i


  • To: Colin Ian King <colin.i.king@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>
  • From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
  • Date: Fri, 18 Mar 2022 00:25:37 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PKGmbYbQmSx4Px24SmQ61FKfkVUbvVzBFa0IqeIXdyc=; b=FbkzdYPclkWOjtAqUqqY4Nx9F1Bml7xTWu+lS85T2rxbrPlg7tff9hEw4nxbFBTCOR5FVbTV09aeRv8n5Fu3Gq/5Y2+agBUWpvzz9IGIZz1yfuJB/nQfyK5qKBkCh9hI8P67uJxz8A0T6ZP9I3gs9S4uYniQ2Mgs/37wXAQsUEXdS6bIqWnrGhEwJYrs95wxeR/a6eJf5FELsjpH9jeO+U7ziA0Bqlh34UwGZtLwHC3fpC0FZ/fo8+Rs/hUiD9IqOIe8xn+YxNjm/MDnXh0f5G+WxETD1XYWfTcWHSqJN3PPQ0hfI1CwaM01rqd9GMW+EDZIxjjKrkexwSxMqGV6gw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WCFw2h5snUFor7boPt029wvxAwhGMIvPjU0XVkHy1z2MfdOby+Wu/dFhh1NNxwtUVAGRKC4oYnRIYjiNjongZd1e4FTR9jMpi5ly4qOT1uGqvVYV2y+JryaWH5UKFBDLffr+iLDiWw3+SH3YbvFaZPPGRdFTF3TR4CHGNtAyyPTIevsi/3uQfg1y2c2on0XQeCHtkqF8CXE1aYBYQ5LyGqAzFHJLIjdltHPLd/hKqagdmGn3v2hh3oTm/Xu88PQME4OnKnzxU3zOzTqduzO5eIrLUxfmmuSuCXOb12uGshVelW603MGL7WWEWDrVgeYFowaipiYKQ+oy8S79+yCbPw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
  • Cc: "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "llvm@xxxxxxxxxxxxxxx" <llvm@xxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 18 Mar 2022 00:25:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYOllPM4KVnPDwzUOWGkhkOkBQSazESJwA
  • Thread-topic: [PATCH] xen-blkback: remove redundant assignment to variable i

On 3/17/22 4:46 PM, Colin Ian King wrote:
> Variable i is being assigned a value that is never read, it is being
> re-assigned later in a for-loop. The assignment is redundant and can
> be removed.
> 
> Cleans up clang scan build warning:
> drivers/block/xen-blkback/blkback.c:934:14: warning: Although the value
> stored to 'i' is used in the enclosing expression, the value is never
> actually read from 'i' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.