Re: [XEN PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves

[Julien Grall <julien@xxxxxxx>]

Hi Andrew,

On 16/03/2022 18:58, Andrew Cooper wrote:
> > diff --git a/xen/common/event_fifo.c b/xen/common/event_fifo.c
> > index ed4d3beb10f3..6c74ccebebb7 100644
> > --- a/xen/common/event_fifo.c
> > +++ b/xen/common/event_fifo.c
> > @@ -165,7 +165,7 @@ static void cf_check evtchn_fifo_set_pending(
> >       unsigned int port;
> >       event_word_t *word;
> >       unsigned long flags;
> > -    bool_t was_pending;
> > +    bool_t check_pollers = false;
> Considering your commit message, did you intend to change this to bool?
>
> Can be fixed on commit.  Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
So far, tools like b4 [1] are not able to find your tag on lore.kernel.org:

42sh> b4 am 
6b84a20b2753130cc62406a0fd14d2708f6f504b.1647455219.git.raphning@xxxxxxxxxx
Looking up 
https://lore.kernel.org/r/6b84a20b2753130cc62406a0fd14d2708f6f504b.1647455219.git.raphning%40amazon.com
Analyzing 8 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] evtchn/fifo: Don't set PENDING bit if guest misbehaves
    + Reviewed-by: David Vrabel <dvrabel@xxxxxxxxxxxx>
    + Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx> (✓ 
DKIM/armh.onmicrosoft.com)
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
 Link: 
https://lore.kernel.org/r/6b84a20b2753130cc62406a0fd14d2708f6f504b.1647455219.git.raphning@xxxxxxxxxx
 Base: not specified
       git am 
./20220316_raphning_evtchn_fifo_don_t_set_pending_bit_if_guest_misbehaves.mbx
This is because they are not at the start of the line. In the future, 
would you mind write the tag on a separate line?
Cheers,

[1] 
https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation
--
Julien Grall