[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/vmx: save guest non-register state in hvm_hw_cpu
- To: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 21 Mar 2022 17:40:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JfZqOObITnHks2qi+5ymyLUquPTDq6tZg3/gvToYs6s=; b=lIX/AwzYvPaGyQ8Fer6rEQd8R+qQhq227d1QJHtVm9aFrFBPZuGJSMXChjoVREhm8hiH+J1NxriTbBji6qHZgS72npmIecLzFmIetL+upPylYzE4FAcpZRN85+/WfEnsnZuT5sTHtJ513sEpECuihl9BZrI64Vqo+tF7aIF10/3E8SFVUx0TMpgZZBrgqtbdKMtku3BeLA7St677nta7zx+X5wzbhGqwnD8unPXuPJ5cWyo93s/HMiZi0FgoUEoPL55XlyF/GHL3V5TLHeoV9d2jQwUeQMGofi+loh8BPf8KAU3Ve0JDbuSj+dVrkKRKtuIM1SXC/1qsW+J8SRBc9A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmW+omQ16DAlTqQhmBrxq5YGBbhVUYwnWRpLPzEHszHVgvtb4jzI5iXH9KGUjs6TsxCxbftjOSF9ogLIZstyd16mM7xQEi8f5lSq1Le6lt/0rjXurA+13nIUfL5ZEqbgocKzHh5YT131fc79rOxZXeyfSPIOqnroicv7JuWP8U8Fq4WFp3oz9w8EKSN/EPOfPG0WFuhFadf/4iuPd3QG/LA/iTaJkIyS9AAs28jZQwkhWVi99kZ0FnnJHthCW0GlKC4MsMslkYv6b4Ad+iEn31rQcyCujmjFFe18DAMNrADGocvOVtuwZOtSC18pxz1hEoQ8ZEytzsI/9X4yZ3iKsg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 21 Mar 2022 16:40:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.03.2022 17:26, Tamas K Lengyel wrote:
> During VM forking and resetting a failed vmentry has been observed due
> to the guest non-register state going out-of-sync with the guest register
> state. For example, a VM fork reset right after a STI instruction can trigger
> the failed entry. This is due to the guest non-register state not being saved
> from the parent VM, thus the reset operation only copies the register state.
>
> Fix this by including the guest non-register state in hvm_hw_cpu so that when
> its copied from the parent VM the vCPU state remains in sync.
>
> SVM is not currently wired-in as VM forking is VMX only and saving
> non-register
> state during normal save/restore/migration operation hasn't been needed. If
> deemed necessary in the future it can be wired in by adding a svm-substructure
> to hvm_hw_cpu.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
