[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/10] xen: harmonize return types of hypercall handlers
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 24 Mar 2022 11:57:25 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1cOJGGdFUrOU8OTTETiNKtBvsn2MASsZFruwBAOawCM=; b=YIUgtwryw43qXKOBZBvtMDDWT0m/WyP47sPpuNqgvLwgmITxqlDTP8zrsLpLoapAoveU01+u+3dNZ8akaeoBsJoymNGz69EynkkDxlakCFuBx7Ty3sJ8VBVehf9I7neYWw7Gas5NoVQbU9rrB2YQJBEd5/HSqSM0Td08tslK38LlFOplBTXxFtyBvSDNjw6Cp7DV8o1hyGlPCTkn8JXFI40fjeAuAr+F/hI7wcj8uYQBZz07DldjG/O58uAxpJOEgKWk3oo4eTJNJTrTJGIGmN/8ducof4qbsiMgwVFy/a8EJS/uRqrsfhcp1Sg0Zh+djqub9+7Kz/VCo/usBEP92w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGANbBnAwEtj0/u47N/NEWPmwRsbWIZaQl9oKRZLkj1Mi9cJBZrsNiF/Vv7AHxixmRhTUa6PC8UpXMbUIxXTWKb2Ny9Ch4KBIJ2mNk4DvPkCpUrBAvMB7zn6X8BY2XdSxAUGkjN+gQ5NDQEQZZgvKAmf2M5Yl+v3uwYxIYPe5DuNtGL+2GOYkuMhaBn6IEGq157JG3Y+guGI7zXS4rKSEK5m7IeCvhaZFdlBKmh79jvqLTGAO6dbKXYWBsNKNDylkaLtXTBfAQYJuOHPdcDnPQTw/Lb96+GY0xERWjeJS9AOXxF3sxRfra6YrhOCIAA4dyw9hurVW83xZB5UOkR8eg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 24 Mar 2022 10:57:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.03.2022 09:13, Juergen Gross wrote:
> Today most hypercall handlers have a return type of long, while the
> --- a/xen/arch/x86/x86_64/platform_hypercall.c
> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
> @@ -4,6 +4,7 @@
>
> EMIT_FILE;
>
> +#include <xen/hypercall.h>
> #include <xen/lib.h>
> #include <compat/platform.h>
> #include <xen/hypercall.h>
So I thought I could apply patches 4 and 5 alongside patch 1, but patch 4
contextually conflicts with the change above. Looking more closely I was
not able to understand (anymore) what the hunk above is good for: It adds
a redundant #include, just for patch 4 to remove the original instance.
In turn patch 5 then also conflicts, no matter what the correct resolution
would be in patch 4 when pulled ahead of patch 3.
Jan
|
