[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] x86/mem_sharing: option to skip populating special pages during fork


  • To: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 25 Mar 2022 11:59:14 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s8wYYiBKEzS1T01ityJi4Un6alKEoH5DKQbVVVMus4k=; b=SS5f6zkOsjIDZy4Gm/vkLS9wwdIFC7c/XkD+6eSA0uVblc/hWVYM0re60FAuA5A2i5+bh5+r//P4OIQgEPCeRgItCM2i82zXpaGV2TPjZ3GQYNtQUQdPFvwsxhrHiNx6jqKzjY0mLqFcJJL2z//VJnAXLlPF0JGgVMo+aMxwA1etUyMIAwHd82qXQwQlFDCIgNpzjuJAEKRsFZgs8jLR2caut+/kLzijuzdZnXGQwWQE6SqBRiYLxTl5Nv+MyjTDh822y4tvflG/7ZB0VMoAjaYluBFDhvRJQMUXsLTrDO7uZodrYxCTMR8j40edv7JRnMHOLevxquZhBCdRWKFXmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nVD81u7NDWD6ubu5OjdZ7SfqyHZuwZS+flXA3bRQG4gsgFBhErC2+1LA9Pq5Dwur6VK+7B82QrF/CAPlA8DFIueHub8p9pBg+bxHTE6YaSW/6XNj1f4LoSoYLo738Nhx5/bfJTTFrWFsB2LN6U5HF5XbUPicrjs0JvJo00qU9PGKbAGaSRx6xKp7Mm6gRRkdKD/BD6Mdwct4O5iCfNzjGoYykLV7vrAZ8x5FADbzGhi7JU9Uujjw/jl65NoYcc1ew6FvsEuVSvILRqcN2xrZNcmwVbCZaJWUE4RL8i8SEABTjiSodahfx3lwEnNUOR/GqxIBtCIyb/kRWPsRpNHUvg==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 25 Mar 2022 10:59:30 +0000
  • Ironport-data: A9a23:lv/6eKmTD94Wdw5kq1fIfkno5gxjJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIXUGmEPquNamqkctwgYIqy9ksE7cPUyN9hSAtrrSBhQiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DiWV7V4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSz8rJfDiv8EkQwRgDQ16EoN25buYGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6mGO ZZGM2QHgBLocj1QNlRKIYAEv72vq17DSgQGkErFqv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCnFSWz3c7FB4SWF20sPS9zEW5Xrp3N Eg86ico668o+ySDUtD4Vgb+pHOCsQ8RX/JRFfE37EeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5t3jX4iNht1FSVFI8lSfPryI2ucd3t/ 9yUhCoGha5Oo+ku7rWmxU7rhx2CloXNETdgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgarsU6zGLoC6TLwJs8w4iPIXM/CdkyfdoElTiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymHxunD6OGM6qlE78uVZ7WJJzYe5UWLdpRrpkhJ5oXS2Pq 4oPXyd040s3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI9cFzN/8T5mOt7E6Q8xvw9vr6Ro hmVBx8JoHKi1CavAVjbNRhehEbHAM8XQYQTZnd3Yz5FGhELPO6S0UvoX8doLON7pb05kZaZj ZAtIq29PxiGcRyekxw1Zpjhto1yMhOtgAOFJS2+ZzYjOZVnQmT0FhXMJGMDKAFm4vKLiPYD
  • Ironport-hdrordr: A9a23:BmBGTKmmSNZ4e8ctJ8iDvtdnEv7pDfPAimdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH LKjfA32wZINE5nJ/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sul Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfoGoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A/eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6Nq+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQf003MwmP29yUkqp/1WGmLeXLzQO91a9MwI/U/WuondrdCsT9Tpa+CQd9k1wga7VBaM0pd gsCZ4Y5I2mfvVmHJ6VO91xMvdfKla9Ni4kY1jiV2gOKsk8SgDwQtjMkfAI2N0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Mar 22, 2022 at 01:41:37PM -0400, Tamas K Lengyel wrote:
> Add option to the fork memop to skip populating the fork with special pages.
> These special pages are only necessary when setting up forks to be fully
> functional with a toolstack. For short-lived forks where no toolstack is 
> active
> these pages are uneccesary.

Replying here because there's no cover letter AFAICT.

For this kind of performance related changes it would be better if you
could provide some figures about the performance impact. It would help
if we knew whether avoiding mapping the vAPIC page means you can
create 0.1% more forks per-minute or 20%.

If you really want to speed up the forking path it might be good to start
by perf sampling Xen in order to find the bottlenecks?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.