[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v4 4/6] xen/cpupool: Create different cpupools at boot time
On Mon, 28 Mar 2022, Luca Fancellu wrote: > >> + > >> + if ( !dt_property_read_string(phandle_node, "cpupool-sched", > > > > This should be "node", not phandle_node > > Hi Stefano, > > Yes sorry about that, I didn’t notice it because in my last test I was > creating pools > with default scheduler, I will pay more attention next time, same applies to > the > scheduler swap. I’ll fix them in next serie All right, thanks > >> + &scheduler_name) ) > >> + sched_id = check_and_get_sched_id(scheduler_name); > > > > It would be nice if we had XENLOG_INFO printks to print at boot for each > > CPU: > > - the PoolID > > - the scheduler name > > Not required, but I had to add them to figure out exactly what was going > > on. > > I’ve added a printk in btcpupools_get_cpupool_id, do you want me to remove > from > there and print here? I don't particularly mind where the printks are added as long as they get printed once with XENLOG_INFO :-) In this version of the series the scheduler name (or the ID) was missing. I was asking because for testing purposes one would like to know the combinations [CPU -- PoolID -- Scheduler].
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |