[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] xen: Populate xen.lds.h and make use of its macros
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 29 Mar 2022 13:42:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Da0u2wt/JglFiSsVTCZaF9E4pnNdkGgZuM1GgmPz5Y=; b=C1+D1mm8bzPT+SgLQ4prZCEQeEwskHSRmm+ecsF9OSTuE/TKvRZ3DOxhfj3Vn/raL6Xy0Y/m8+JGjpsJtt5o9T6JviyTE6lD7gDJaEN7IxS/7jiYf0xt8+YKqYtaWpmHsmsl4htDlfKLaZqnDI9LocL/3NcZuWLTX5kdgku2tqhlo24L9BIQZXq/52lVDnmZECHFBibsCL/s/a9ie1M0Hwsa8aELwN8b/kGl9qRVvEhidHBjFx1rRp1ucLrZPOLTbetYr65WYg2PFQ+dWKHeOQu5whe7tRPwPkb6F+lCv1msnXSxqlBdTuCtVKAwiC5Jxix5Pa99E2BF2kfHnLkAUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9capGzp+1TtwMBTa68yOq0XZv9qfVSnRIjqyjZo1e5vkuLUAigUPtDZEL3uy+xU8aFkSw1gh7Bb7rhvhEj969tMOdu0PPYaYE0+N/GcMbNrHgYsPuW/vAPIpm6vMvrnRNpnhcds9YyS7RyrK0XErvgJsLHnjFlHtMVlCwsbcNTzc3yoSzZapbkPWFy3s/OObzJy/OBOhloPL3eXPwnCe4AB/Dr0jiXagvsEL3twZlGmxLufHV3LQnKFzEVvd4SiC99slL2ITeaLsakzQx+ux/H4IuA0aiTPqdkmODddR14sic1C8UY6jbXPL4ixG8gEjpa9BdZnipXZwhFlgZXKnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 29 Mar 2022 11:42:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.03.2022 12:54, Julien Grall wrote:
> On 29/03/2022 11:12, Michal Orzel wrote:
>> On 29.03.2022 11:54, Julien Grall wrote:
>>> On 22/03/2022 08:02, Michal Orzel wrote:
>>>> --- a/xen/include/xen/xen.lds.h
>>>> +++ b/xen/include/xen/xen.lds.h
>>>> @@ -5,4 +5,104 @@
>>>> * Common macros to be used in architecture specific linker scripts.
>>>> */
>>>> +/* Macros to declare debug sections. */
>>>> +#ifdef EFI
>>>
>>> AFAIK, we don't define EFI on Arm (just CONFIG_EFI). Yet we do support EFI
>>> on arm64.
>>>
>>> As this #ifdef is now in generic code, can you explain how this is meant to
>>> be used?
>>>
>> As we do not define EFI on arm, all the stuff protected by #ifdef EFI is x86
>> specific.
>
> I find the name "EFI" too generic to figure out that this code can only
> be used by x86.
>
> But, from my understanding, this header is meant to contain generic
> code. It feels a bit odd that we are moving arch specific code.
>
> To be honest, I don't quite understand why we need to make the
> diffferentiation on x86. So I guess the first question is how this is
> meant to be used on x86?
We produce two linker scripts from the single source file: One (with EFI
undefined) to link the ELF binary, and another (with EFI defined) to link
the PE/COFF output. If "EFI" is too imprecise as a name for the identifier,
I wouldn't mind renaming it (to PE_COFF?), but at the same time I'm not
convinced this is really necessary.
Jan
|
