[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/3] retpoline: add clang support + Kconfig selectable


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 30 Mar 2022 12:35:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=itRVDMm65ODpsIpnEIn3YUUtIrx0s+IAC6E73fyZbNo=; b=FsY0OvRVzwAlPh94kwjygHS3HvRqNuFDrTyIS3sblrpokxk9m4aYY9WpPkv6B0UyF3xG/iUJd15xnPL9meCNft+2EY0Yqmvxut5AaAyxuj6jUJIi0K8YvXJtX4xLoQuu5PZh6rtR6nG/E9vVdbP8G1XhGLSON5lYvIAKQOdgrzGZyctYdTLHFbu2ZtxNlfUANUg7yYHT5nqaUAK2x7a9RcQ2Y0eq3bV1uAIE8Gx8TaEIlwtQRGo0jgF0HUO2YrW3CtasM23iryhpyca4p4axDCCR8ym8A0/4Lq2RRe1z0KnTSAWMxshG9xzQYizw3FqVLJIa/7aZu+zBxG1OsIUv3w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+HRIyjswIchgtPZFsXZehXryyDJ4YDHmlXqCSA/i6/YRPrJSIMwkgwSmTLixNepJV8B66X1znTgbmLydqVlPg76GKnaSpbGlBpEWrdRGv9fSL6+MkFgd674cs2UXT3nxLJP+T6nAwcup9lJOB0RCtPbRI3Ry5aDKf/xuNLjEdQS8JaR7urAwo8j7w+he7t3vaa3gf03CkOGiKvJxck5XdHNp6Rml7lP+RCYGGEFO5pIQJs73GQLH2Fk5X8Kcz/c/jVENW8J7j2hfP8cO4qjmZL9ofQdEV5FJhYpmi3nsorsk6xAo9EzlsGGH6mAr9GAzvU8kmvSR9lCoc3xu/NP0w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 30 Mar 2022 10:35:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.03.2022 12:21, Roger Pau Monné wrote:
> On Fri, Feb 18, 2022 at 03:45:12PM +0000, Andrew Cooper wrote:
>> On 18/02/2022 14:34, Roger Pau Monne wrote:
>>> Hello,
>>>
>>> The following series adds retpoline support for clang builds, and also
>>> allows the user to select whether to enable retpoline support at build
>>> time via a new Kconfig option.
>>>
>>> I've tried adding a suitable description to the Kconfig option, but I'm
>>> sure there's room for improvement.
>>>
>>> Thanks, Roger.
>>>
>>> Roger Pau Monne (3):
>>>   x86/retpoline: split retpoline compiler support into separate option
>>>   x86/clang: add retpoline support
>>>   x86/Kconfig: introduce option to select retpoline usage
>>
>> Thanks.  I think that's looking much better IMO.
>>
>> One thing, we want CC_HAS_* for consistency.  I can fix this on commit.
>>
>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Could the patches be backported to stable-4.16?

Hmm, generally I'd view them as a feature rather than a bug fix, but
since you're explicitly requesting their backporting I guess I should
rather look at them from an improved-security angle.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.