[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Grab the EFI System Resource Table and check it


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Thu, 31 Mar 2022 12:05:58 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjKb2H8J3NmCttTZe7q9rioXkJslGBgXsPhk+4Tacfw=; b=Wba7xWHEuU28KJJZ7GZDiEGkSEKweM2J7ygGmH48tNbiBRDK5fwgVGQwTvkQ9LGA69Tbv1n6TZB5I/Z1MlgQsQFZmc5ZdK1Lp5wMOYiChTu3wzudPerl5TT6fipSENUODsR/Qzaj6KIap1a5MQZ+6TsvFJJYMMY6X04/H/krLj1+m0IbsfwzSnh+SsQKHM/odbWD+B8VrcRyem8ex0biCqKYuxkjrm3TBlYsmrUA6f1s1q3+d4MgQzo3/cYE83gPQURfHi6rqbUd70eKdQX/XUxFfk3mt2Hk7iveAiHyAwR+WREhmExvfZbsiKv8MhAOaCvJH2DSNQlADsKIIfKhyg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JRLhS7Wcce7PhmQ5ki4EW/4p3flxyja9K/bI1ombBOsr/Hy7xB5VmEbI3ftwkgwAUTSvCdzEfP8SkdVZG18af3j1meELdmX5D955totcGhNvazxadbFzVwhsVkduni5U0nLM01GyIvPd7btink6v6ncBm/gK3o9LNK0AXECEEDGIRqFnX46sFU8r3OgmWFwOxVCdI1R/xQlujgVEgE5lh6VvzZfrxbncMHjZ3WYUDgldB1cnRiRbjQy9gahHquVz+T7pWRreBZSIyAgecE5YuO4dBBtLvS1o72gVE43C2Z2HVY7751iSWFe2Z0Uy3PnvuKKO7AyLKNGUm/w/s72yWg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 31 Mar 2022 12:06:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYRHEH4zzX/uDlcEa4/lbFmRQ7HKzZEkOAgABR+QCAAAI8AA==
  • Thread-topic: [PATCH v2] Grab the EFI System Resource Table and check it


> On 31 Mar 2022, at 12:57, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx> 
> wrote:
> 
> On Thu, Mar 31, 2022 at 07:04:34AM +0000, Luca Fancellu wrote:
>> Hi,
>> 
>>> 
>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>>> index 458cfbbed4..398a2411a1 100644
>>> --- a/xen/arch/arm/efi/efi-boot.h
>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>> @@ -187,7 +187,8 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
>>> 
>>> static EFI_STATUS __init 
>>> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *map,
>>>                                                UINTN mmap_size,
>>> -                                                UINTN desc_size)
>>> +                                                UINTN desc_size,
>>> +                                                const 
>>> EFI_MEMORY_DESCRIPTOR *const esrt_desc)
>>> {
>>>    int Index;
>>>    EFI_MEMORY_DESCRIPTOR *desc_ptr = map;
>>> @@ -199,6 +200,7 @@ static EFI_STATUS __init 
>>> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *
>>>              desc_ptr->Type == EfiLoaderCode ||
>>>              desc_ptr->Type == EfiLoaderData ||
>>>              (!map_bs &&
>>> +               desc != esrt_desc &&
>> 
>> I was going to test it but this line is breaking arm build.
> 
> Not too surprising; I don’t think I actually built this for ARM.  Can
> you post the error you get?  I’ll send a v3 once that is fixed.

I think I cleaned my logs, but it was an easy one like “desc is not defined”,
probably you were looking for “desc_ptr”?



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.