[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/8] x86/EFI: retrieve EDID


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 1 Apr 2022 10:15:06 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NyIcrG2CditFEVAGnksGjvybLKcGcz1xBLOn6iY9TKw=; b=Aln3wi6oRObG2PP29x6qCMfyWivzd9pFJrT9fPN6irk8jGCGtvtcZdsVzam6N6kiUJPcNbZe+7bnPN3hESLE1SwEBxUrHSWNRZjXHqmPnol7GFP8SlYa8G/j1au3dGxKJ9lF6UXiTxKEQPdnImWJvk2RWRVNYo+D7XE1XUwVtuhWN0CUodzEniQekFD3eu40I0Kb3kUtMJBGskU6F70cZl1DYFpELWxfqZ5SeBAdvUQHQGRki4xjb6TSveLVtp/5cQgMA8I6DajhO2rq/J5IUCBwq2GkkXa9H/g7CnFi9/+tZoMGSzw6QBypAoqWpZ/+ONPEMg57JX0eTPPXaaeU/A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c0dD9hpu3Bs6O2x1bzPseLoEAhB8jX+FBJ4frcW58hdhJy9YDuJs0iAjJjcRNEe0okaTGXo44pseIaMhozKwNH9aZ8ZRSN7jx1Snxw2AP3x8ZL+M11nMC3IvEsn3uU1JPikxBnCwv8WPW4A0AaNCrxxVPxi39tTMgxsMY6FB6TiN8M6be35/f3PktzD1vEvXVR6WE+l77XXMylw+c8JfJSx04X1H5nLO2KDetcCD1ZULX4DNQSmimX/G6wp7oIaeWuT0CVDtMlMKCDDOetVjruqBUmVlETgfK5z0wXVGEqPDJTH/hpZFU8R4iMqhgcy3VXeEOQhDK917a0UH0pXHog==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Delivery-date: Fri, 01 Apr 2022 10:15:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYROQoBKP2/eH5XEKfptm0g77zk6za2O6A
  • Thread-topic: [PATCH v4 3/8] x86/EFI: retrieve EDID


> On 31 Mar 2022, at 10:45, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> When booting directly from EFI, obtaining this information from EFI is
> the only possible way. And even when booting with a boot loader
> interposed, it's more clean not to use legacy BIOS calls for this
> purpose. (The downside being that there are no "capabilities" that we
> can retrieve the EFI way.)
> 
> To achieve this we need to propagate the handle used to obtain the
> EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
> EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Hi Jan,

For the arm and common part, the changes looks good to me.

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

I tested also the whole serie in the sense that it boots properly on arm,
unfortunately I could not test the functionality.

Cheers,
Luca




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.