[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 1 Apr 2022 12:02:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGL7PQ5uEv/hO+1X+bG0wIFKuVWr6PHkDoNabo1ZKV0=; b=GWYczA6VOMrdKAyCktbAt9Ff9DbJzC67fAWcJYzwKpd0rojKvL976JWpPBsk95ei0NcyRi3McIWXW7NG3JLHtV9uzN990rfBe5bwLOl8gfEen1uo0Kxa1YYOtVqgui9h666GnB8oknw0DoCsJdIdjpfZVE67PY7yavzwY3zmq1hz+pE6mEkyVinSayzLQIG41uaKieNYCgGN4z3CTvYzz7J+PfU1FsFowKnzKohN8/9sqs2g6wQ0DtO3x5EAKrgtxtqX3/mH2XhiIl1hvkAhA39+BBOQQJYocHnCcS28iNsptug/TUiqv9cBh1D2lLJFbeT6zJYJEpXs10Pg4NQ74Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RH8WAvpnQqAindGz+LTE9plfcKI669qMkDe7Qv9pGZTjaVWVHF46XvGe1EyBmuAUUtkrRZSPIUtwtbqEA3hQRmo7etxR7Q1KYpOriotxZWh0v6CERL8lfwdCtQQnYcLbs1KzLwl6jTtfMNuqibYR6TUPqNZYB4NGBmtLu0OIPZfKivtiXXJ/h+wKdqR4/VGBOkqjU0icpieTNG9Aynf+yqz7Il+sALDJg/ew6tmQtasVKZbXbQrqhS8dnKeV0EMzKPlh1sXV8EbSZVboF6+hUt82DiZ3iH0y8QiOwc2vD9Q4qcO7DklizcWED4WHMeDug0aoJGA3O7ZDb8IwLhpDDw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 01 Apr 2022 12:03:22 +0000
- Ironport-data: A9a23:bphlkKBvOxf9dhVW/6rjw5YqxClBgxIJ4kV8jC+esDiIYAhSlGxQk DNbHCvTJK7JMVJBSKkiOom3908H68XdyINiHFdv+ylkFyJE8pKdXt+SfxuvZHqccsOaFktp5 ZlPN9fKd5poFnbS9xrwYrO+8iAi26rTLlaQ5JYoHwgoLeMzYHtx2XqP4tIEv7OEoeRVIivQ6 I2p/caHZQCrhjV6a2xP4PLe9h8z4Pn4tW8R5gA3PKEXsAfSmUdOAcNEL8ldDZdZrqq4vAKeb 7yepF1s1jqBp3/BMvv8zvCjNBdirof6ZWBisFIPM0SZqkUE93RaPpoTbqJGMx8L02zRxbid9 f0W3XCOYVZxVkHzsLx1vylwS0mS6oUfpdcriVDm2SCi5xWun0nEmp2CP2lvVWEswc5lAHkmy BAtAGtlgiZvJQ6B6OnTpuFE3qzPJSRwVW8VkikIITrxVZ7KTX1fKkljCBAxMDoY36hz8fjii 8UxWAddaDrARh1zMHQxJbMdxqSDiHD5bGgNwL6VjfJfD2n7yQVw1P7mMcbPe8zMTsJQ9qqaj juYpSKjWEhcbYHBj2remp6vrrancSfTd48VDrK1sNJ3hlma3kQYCQEMVEv9qv684qK7c4wAd RFFonJxxUQ03HaoUNTRRCykmT2/7jEyZfZ5VOYquTjYn8I45C7GXzNZH1atcucOq8seVTEsk FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyKkRpB/SStdoEIauk8b4Xzr3x li3QDMW3utJy5RRjuPioA6B02nESoX1ohAd1zjlWkylywNFbq2DSq2Lsxvw4/9GM9PMJrWeh 0Qsl8+b5eEIKJiCki2RXekAdI2UC+a53C702gA2QcR4n9i50zv6JN0LvmkiTKt8GpxcEQIFd nM/ru+4CHV7GHKxJZF6bIuqYyjB5fixTI+1Phw4gzcnX3SQSONl1Hw2DaJz9zq0+KTJrU3ZE c3EGSpLJSxGYZmLNBLsG48gPUYDn0jSP1/7S5Hh1AiA2rGDfnOTQrptGALQMrBmsfne+FSEr os32y62J/N3CrKWjs7/q9N7ELz3BSJjWcCeRzJ/KIZv3TaK6El+UqSMkNvNiqRunrhPl/egw 51OchQw9bYLvlWecV/iQik6MNvHBM8jxVpmbX1EFQv5gBALPNfwhJrzgrNqJNHLAsQ4lqUqJ xTEEu3daslypsPvoGpFN8Cn/N0/LHxGR2umZkKYXdT2RLY9LyTh8d74ZAr/si4ICyu8r8wlp LO8kAjcRPI+q85KVa46tNrHI4uNgEUg
- Ironport-hdrordr: A9a23:deD4YqwZoaYwZVHj6qluKrPxn+skLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9IYgBdpTiBUJPwJU80hqQFnrX5XI3SEzUO3VHIEGgM1/qb/9SNIVydygcZ79 YcT0EcMqy/MbEZt7eA3ODQKb9Jq7PrkNHKuQ6d9QYWcegDUdA50+4TMHf9LqQCfng+OXNPLu v72iMonUvERV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCGlaDPY0L3ErXQBepF8bMtiA2jkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0DAfeX56tQ0ubWIyUs4YkWUkxjIfLH7AJlOM1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgE082IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBLB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+laGjMiq9NllVcQ6dv/22vaIJyIEUbICbRRG+dA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKM5GC/VzGwcY0kWHMmttuUzSl6zbLyqA
- Thread-topic: [PATCH v2 02/14] x86/P2M: introduce p2m_{add,remove}_page()
> On Feb 23, 2022, at 3:58 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
> Rename guest_physmap_add_entry() to p2m_add_page(); make
> guest_physmap_remove_page() a trivial wrapper around p2m_remove_page().
> This way callers can use suitable pairs of functions (previously
> violated by hvm/grant_table.c).
>
> In HVM-specific code further avoid going through the guest_physmap_*()
> layer, and instead use the two new/renamed functions directly.
>
> Ultimately the goal is to have guest_physmap_...() functions cover all
> types of guests, but p2m_...() dealing only with translated ones.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
Description reads much better to me — thanks!
Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Attachment:
signature.asc
Description: Message signed with OpenPGP
|
