[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 1 Apr 2022 16:21:35 +0100
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 01 Apr 2022 15:21:50 +0000
- Ironport-data: A9a23:r+kkkai79ZZCMjgikXUoh724X161CBAKZh0ujC45NGQN5FlHY01je htvXWCHPfaKYmP1Ltpwao6x9xsH6p+AzdZmHQs/rX1mRHsb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vU4 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YQc5O/aUwe8faURVDXtQPKtv8e/7AWfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bknhm0THeC+dgWZ3ZSr/GzdRZwC0xloZFGvO2i 88xN2UxM0SYMkUn1lE/LJU4rcykpSXFUAJq9VnMv44t6Ffz5VkkuFTqGIWMIYHbLSlPpW6Ho krW8mK/BQsVXPSPxDzA/n+yi+vnmSLgRJlUBLC+7uRtglCY2ioUEhJ+aLegiaDn0AjkAYsZc hFKvHp1xUQvyKC1ZtntWkbg+XWGhEMRRYB+EusT4VGx6rWBtm51GVM4ZjJGbdUnsuo/Sjory kKFkrvVONB/jFGGYSnDr+nJ9FteLQBQdDZfPnFcEWPp9vG5+OkOYgTzosGP+UJfpvn8AnnOz j+Dt0DSbJ1D3JdQh81XEb0q6g9AR6QlrCZovm07vUr/t2uVgbJJgaTytjA3Ct4acO6koqGp5 iRspiRnxLlm4WuxvCKMWv4RO7qi+uyINjbR6XY2QcVxqGn3oSbyLN0NiN2bGKuPGpxbEdMOS BWO0T69GbcJZCf6BUOJS9zZ5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziF6Lq 4wGbZvblk03vS+XSnC/zLP/5GsidRATba0aYeQOHgJfCmKKwF0cNsI=
- Ironport-hdrordr: A9a23:uzpfXq1pXznMzD6MBM8MmAqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Apr 01, 2022 at 03:04:44PM +0000, Andrew Cooper wrote:
> On 01/04/2022 15:50, Anthony PERARD wrote:
> > On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote:
> >> +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none
> >> +
> > I think making modification to $(EMBEDDED_EXTRA_CFLAGS) outside of
> > "Config.mk" is confusing and would be better be avoided.
>
> EMBEDDED_EXTRA_CFLAGS in the root Config.mk is conceptually broken and
> needs deleting.
I'm asking to remove "-fcf-protection=none" from the broken variable
EMBEDDED_EXTRA_CFLAGS, and instead only modify the CFLAGS variable of
"tools/firmware/".
As this patch show, making modification to EMBEDDED_EXTRA_CFLAGS outside
of Config.mk doesn't work because changes doesn't propagate.
So the modification I've ask for the patch goes toward deleting
EMBEDDED_EXTRA_CFLAGS, like you want.
Cheers,
--
Anthony PERARD
|
