[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] platform/cpufreq: add public defines for CPUFREQ_SHARED_TYPE_


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 7 Apr 2022 10:48:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNz4rY8TQQ7ymti0pAQe70QDxUDiKhQhvx6bvBnXNRw=; b=WimmknB5p984O7vBD4m/kbxupTeCPk6HJmdSCm2BneUtKWm4d5n55oK/FZvzuideu0qS5AFm1bH1LjyKYkbVwpL0Oe/vvUqymKxtfGr2nG6uQ4QWvtIZiKSRfrlG+ZliA3pMUBqAxoH78QBQv/FHEkNGyqLks0Np4jH3n7/qNsYzlGn47Yb1gArt+wIG7VEbYMFGYaVyBbH8KeLd+/yZKHyW8+NuqW/GLGeFWbmB0X7Q5dA9lo1iZL1Cu76hDoyei+Sc2O+9Jid1OO8P4s4ZYKNaxAm/WSWYebFUxjT1yJs1GoQtWtecV0JzWNVN0bIgxw5BfGCTtDYuz0nHmXsDqw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uh8LrjGgeGzZhSH2YDxvoDkvDCm7IsJoK49OgIKeF5Q3JBrI88pbznsRX5vP5ARG5vYYiPb2Yv3B59PLCIS5It0AqlmCCKtSRybGM6QhAFlL4MMW7rwkO5opTlRH1/BFJF0L89/sSMzJdKhKzzW2zHJI7il00uWuLP8eKUkwdnEfK79+RdB/2980uaGvMT8wptIxM303CGc3ncUSAmC9RMPOagzkxPk6cQAO8bgaAoUj6zkqtzlEf31RLEJiLQ3qMw8+IKe0fcEDSOSVTLDIZtIFSueAkKe4J8wfWrjBLoeXE4jU2SciZzD57zeNMd8jF5sfU33tq6cIPN3KTZ1CUA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Apr 2022 08:49:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.04.2022 10:18, Roger Pau Monne wrote:
> The values set in the shared_type field of xen_processor_performance
> have so far relied on Xen and Linux having the same
> CPUFREQ_SHARED_TYPE_ defines, as those have never been part of the
> public interface.
> 
> Formalize by adding the defines for the allowed values in the public
> header, while renaming them to use the XEN_CPUPERF_SHARED_TYPE_ prefix
> for clarity.
> 
> Set the Xen internal defines for CPUFREQ_SHARED_TYPE_ using the newly
> introduced XEN_CPUPERF_SHARED_TYPE_ public defines in order to avoid
> unnecessary code churn.  While there also drop
> CPUFREQ_SHARED_TYPE_NONE as it's unused.
> 
> Fixes: 2fa7bee0a0 ('Get ACPI Px from dom0 and choose Px controller')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:

> --- a/xen/include/acpi/cpufreq/cpufreq.h
> +++ b/xen/include/acpi/cpufreq/cpufreq.h
> @@ -78,10 +78,9 @@ DECLARE_PER_CPU(struct cpufreq_policy *, 
> cpufreq_cpu_policy);
>  extern int __cpufreq_set_policy(struct cpufreq_policy *data,
>                                  struct cpufreq_policy *policy);
>  
> -#define CPUFREQ_SHARED_TYPE_NONE (0) /* None */

I realize this is unused, but do we really want/need to drop this?
I think it is used implicitly right now by assuming the value would
be zero; this could do with making explicit, in which case we'd
need the #define.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.