[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time



Hi Luca,

On 07/04/2022 10:52, Luca Fancellu wrote:
+void __init btcpupools_dtb_parse(void)
+{
+    const struct dt_device_node *chosen, *node;
+
+    chosen = dt_find_node_by_path("/chosen");
+    if ( !chosen )
+        return;
Aside when using ACPI, the chosen node should always be there. So I think we 
should throw/print an error if chosen is not present.

When you say error, do you mean like a panic or just a printk XENLOG_ERR and 
return?

You seem to use panic() below. So I would also use panic() here as this shouldn't be expected.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.