Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote:
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just one comment below, which can also be taken care in a followup
patch if you agree.

> ---
> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().
> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d
>      return rc;
>  }
>  
> -#endif /* CONFIG_HVM */
> -
> -int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l,
> +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l,

I guess switching the gfn_l parameter to be gfn_t gfn, and then
defining:

unsigned long gfn_l = gfn_x(gfn);

Was too much churn?

(this is just so that the exposed interface for p2m_add_identity_entry
is cleaner).

Thanks, Roger.