[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 4/6] xen/cpupool: Create different cpupools at boot time


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 8 Apr 2022 13:58:55 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K069cJ/0fzb1j3nlccwM8sH1TZx0KZliOM5PfUVmheY=; b=NIWbNgPS8vSe35iOll22Aw8WI8MRob5FZsxmjb1Mx1P0wtCfJDsI9oUrSXWzi2PU5DPqQigBxzhJ7PMLkJQwtgbpcxswQk87L/s0YD+vuH6243feQzHF327G9mzynzpOKoSa2fk/8GMGR4nPnLRNuz4s4VytkIjVOJggNs+YK4b5HQU/9u1QXuakoea0QqtCZWQ8FU4ZtqJlvuIC1GZAfqNAva0I5oEER1drj8wFo+YcBSDL6AUHH8zpfenDk30az4zvEC1z9yFCOqlbQnfSf+8fD79BX/r5l3svHPPHkld5k3tzoKqWSeecZVq1jUhTPNr0ZKjaBSpy7vY7yhXy9w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZHYPR27/DlfsMxIZq9eHnTZvzeRcCbBApMPneaXO11JUldFX33sGokcrCtlJR6lfnhoX1xebYRfaUrfXc56gaNhpZMzGAuiFwdOBRa5FbbUx7QWLIN7tf2DgTn2Iy43bKyZBTDZdPXbIgTTD58t7tTnk85k9R93JI7atscZ4PoReMz/2Z4UMAov8wo4nhFSSL4kz1CKvL6frfVt3V9DZpco1AZi2w4U2nIZwMZNE6ijoxxYYMCLJVgWWpBZPN3O+NuVFu46NX8Txa99iHqwEc0J1wkH+uIlgBL7zUkFBzDUKhpRVf1kMJavNeqAAOa1pkc6d0zgTgp1+EllFcaWoQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 08 Apr 2022 11:59:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.04.2022 13:37, Luca Fancellu wrote:
> 
> 
>> On 8 Apr 2022, at 10:01, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 08.04.2022 10:45, Luca Fancellu wrote:
>>> ---
>>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
>>> xen/arch/arm/include/asm/smp.h         |   3 +
>>> xen/common/Kconfig                     |   7 +
>>> xen/common/Makefile                    |   1 +
>>> xen/common/boot_cpupools.c             | 207 +++++++++++++++++++++++++
>>> xen/common/sched/cpupool.c             |  12 +-
>>> xen/include/xen/sched.h                |  14 ++
>>> 7 files changed, 383 insertions(+), 1 deletion(-)
>>> create mode 100644 docs/misc/arm/device-tree/cpupools.txt
>>> create mode 100644 xen/common/boot_cpupools.c
>>
>> Under whose maintainership is the new file to fall? Without an
>> addition to ./MAINTAINERS and without the file being placed in
>> xen/common/sched/, it'll be REST maintainers, which I think would
>> better be avoided. Would it perhaps make sense to have this as
>> xen/common/sched/boot.c, allowing other boot-only code to
>> potentially be moved there over time? This would then also avoid
>> me asking about the underscore in the file name: Underscores are
>> a somewhat artificial thing for use in places where dashes can't
>> be used. Yet in the file system dashes are fine, and dashes are
>> (slightly) easier to type.
>>
> 
> Ok I can put the new file under xen/common/sched/ as boot.c, should this new
> file be under this section?
> 
> CPU POOLS
> M:  Juergen Gross <jgross@xxxxxxxx>
> M:  Dario Faggioli <dfaggioli@xxxxxxxx>
> S:  Supported
> F:  xen/common/sched/cpupool.c
> + F:  xen/common/sched/boot.c

If it's to hold general scheduler code (which this shorter name would
suggest), it shouldn't need any change to ./MAINTAINERS as the
scheduler section would already cover it then. If it was to remain
CPU-pools-specific, then you'd need to stick to the longer name and
put it in the section you have reproduced above.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.