[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros



Hi Michal,

On 05/04/2022 10:16, Michal Orzel wrote:
  #if defined(BUILD_ID)
@@ -109,12 +104,7 @@ SECTIONS
         *(.data.schedulers)
         __end_schedulers_array = .;
-#ifdef CONFIG_HYPFS
-       . = ALIGN(8);

This will be replaced with POINTER_ALIGN which is 4-byte on Arm32. AFAICT, there are no 64-bit value used in struct param_hypfs. So it should be fine.

That said, I think this is worth mentioning in the commit message.

The rest of this patch looks good to me.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.