Re: [PATCH v5 2/2] xen: Populate xen.lds.h and make use of its macros

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 11/04/2022 08:03, Michal Orzel wrote:
> Populate header file xen.lds.h with the first portion of macros storing
> constructs common to x86 and arm linker scripts. Replace the original
> constructs with these helpers.
>
> No functional improvements to x86 linker script.
>
> Making use of common macros improves arm linker script with:
> - explicit list of debug sections that otherwise are seen as "orphans"
>    by the linker. This will allow to fix issues after enabling linker
>    option --orphan-handling one day,
> - extended list of discarded section to include: .discard, destructors
>    related sections, .fini_array which can reference .text.exit,
> - sections not related to debugging that are placed by ld.lld. Even
>    though we do not support linking with LLD on Arm, these sections do
>    not cause problem to GNU ld,
>
> As we are replacing hardcoded boundary specified as an argument to ALIGN
> function with POINTER_ALIGN, this changes the alignment in HYPFS_PARAM
> construct for arm32 from 8 to 4. It is fine as there are no 64bit values
> used in struct param_hypfs.
>
> Please note that this patch does not aim to perform the full sync up
> between the linker scripts. It creates a base for further work.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall