[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] AMD/IOMMU: replace a few PCI_BDF2()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 12 Apr 2022 11:37:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o/T0vPYmoer4+e0tl/wDRTRTIttKBw2hVazDdcDYM4w=; b=IJmbcKu2Rc3yhweb+Nv6hujAQLqz1HTjIXrwkWO2vxfRG++CeGE88d8mT/gEc3yjz7mR5zEZT7RXwEuBA/+cSDfpZ+vHsbicK9BkVqCMxHTdPMso1Op+CgE5ap0zDRTpfkSWDAdxV6hz+b58bqzkoUJ+98pt/s/q1rTYuevPeaJAXnaFcdzKhS2keSw+rwlXKWX3UMDTjc1exKCqy+6qndUs9chET471RmuiY4FzkTZo1nsuamldTLXSii23Jm4zV0Oqhm949sZR4mR/Wljpjh0vs6+DE8vehtxJyTKCKmB1xNl2fp4E9B8Gyh5hzQq/FSlVP7fjXkLBw4ntomZejQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0y0v55D6fhx9qYPAeldAmaNpNppc5cwh/NYuBAxPwh14eJpFztHPRhJyn3BtMjwMnaOCKb/7ZcG/U+w0WVNiFWIh2vEPrw8Yu/ypekDxBqUYWOAs+xBlIYjbLwLPYYotdZ9Wy/0fpWD1GYkApQehrhpOABHAAj34Az/GFBBNn6MuLMWDvjZdjxH2nvkn6XqeeCwLEuZEnajHt/Q66CZGd0zMHQLQGg51B5Wshb+MK2JWFhCTPmbpITH+hNClp4j2h+hH5BsObM6f1fvQh97JlishM6zBE16srS425IMwJNaO/n95aU2F/GdkO0Jl5T09sXlrfYhXJ4T2HlAtkg9EQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 12 Apr 2022 09:38:20 +0000
- Ironport-data: A9a23:g0AJqKhcTYS7RuVYqhNjFaFeX161dhAKZh0ujC45NGQN5FlHY01je htvWG/TO/fcNzP1coonO4i0/RxX6JHdz9JlGVFs/3wwEH4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1rX4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YUQrPoLGgcYSaCVVNXsmGYhp9oTAGXfq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP 5RCOGs3BPjGSwBEfXQpGb0doMGt2nTDWDpipECom4NitgA/yyQuieOwYbI5YOeiXcxImm6Iq 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcV56gGiwLP27D2lC05eFhpkR9Ids/c5EGlCO kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQ2mY/ tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtACzARVodt/xory9U J4swZb2AAcmV8zlqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRk1Y5lcKG+5O RKJ5Gu9AaO/2lPwMsebhKrrVawXIVXIT4y5Bpg4kPITCnSOSON31H43PhPBt4wcuEMtjbs+K f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq Ig32grj40g3bdASlQGLqdVDcg1QdSFT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5 XazRglTz1+XuJENAV/ihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:GNNIdaqJ98iegwV6yNgAOqoaV5vJL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu v52iIRzADQBkj/I/7LTkUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF K12TDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2+ XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LvEbQN/L/AEqZNScxPf5UZllsp7yr h302WQsIcSJQ/cnQzmjuK4GC1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+ NjZfusqMq+SWnqLkwxg1MfgOBFBh8Ib1S7qwk5y4GoOgFt7T5EJxBy/r1cop8CnKhNP6Wsqd 60d5iAr4s+PfP+XZgNdNvpfvHHeFAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 11, 2022 at 11:37:52AM +0200, Jan Beulich wrote:
> struct pci_dev has the wanted value directly available; use it. Note
> that this fixes a - imo benign - mistake in reassign_device(): The unity
> map removal ought to be based on the passed in devfn (as is the case on
> the establishing side). This is benign because the mappings would be
> removed anyway a little later, when the "main" device gets processed.
> While there also limit the scope of two variables in that function.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
