[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/8] PCI: replace "secondary" flavors of PCI_{DEVFN,BDF,SBDF}()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 12 Apr 2022 12:49:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XZidaaqWsBZw+HSoEiwUZExyB7+RrDa+U4o0PoOfqZE=; b=gXPm63DDpWGk0tAhw42bX02OfUrXGs3t4CpqhHYoDMaqDQcoAmpAk5HKflVub9yj5/moB7ZQMdmRSCUBaaP2xJbvva7E8stlfY157HC6Lwy5H0AStbm5Xlg0Qzr+TzCXUhMeDk291Xu+Wi7ELzsWnZI5c08AdM48d2Ifv6gPDFvElZ9HwoV9EKAm276cLC53nViLBESNOKKiYq5Y6Cq2NF0CG5FS+YGh4QXwW+KV+5ZzjjWzMe4XvI8Z2Mc7YscD3P8H+L/+coiglGpX/SyVX5mfse+q6kYbhpndabYNHboUB7csh7Mq0IXHIOraXh/9/u5dTgzyLfNzLfvdlJxtYw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DnZq6RXpt4Z2XQpFH9DPnuP5oNsRHFmY4Q5Yo9HrV0TedUzmjm/y41j757Mm1wxjeaYyGpYWtT0ipDoiscMTYWm3REWXeQEHg7w5W2taNEZjYavuAooNMjjhIGlAfDW+Pzq7UiFVOjCsc448e9tfpjc3vHdbTrDvt9nXouzrIakExU0fkt0eFojbyBIESgr6Lhh9QCcKTl6R9BFjs8tMUBjDP7ZfJMCRHYHoUAKIA47quDDwKqbPJn/DdKA4RU88KfWPA4tvqbZBISqZLhDqSfriO/wQ8/SEYL0MoGDIrwXfNrT/xNLmgqwTpNpFeoblr/Er7wi0+hQ63NdO19BTLg==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 12 Apr 2022 10:50:32 +0000
- Ironport-data: A9a23:gJvCOqLpnslod5gkFE+RG5UlxSXFcZb7ZxGr2PjKsXjdYENSg2EEx zBJXjqBaf/YazP1foh+PIW09xkPsZbWztNgQQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA148IMsdoUg7wbRh3tcy2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 PV17p+iYyZ1Ap3jqNYGXzhbEx1RP5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glg3p4eQKiDD yYfQRZpUk/xTg9fAwoWFpxmvdq4r2v9fhQN/Tp5ooJoujOOnWSdyoPFMsfRe9GMbdVYmACfv G2u13/iHhgQOdibyDyE2nGhnOnCmWX8Qo16PKK83u5nhhuU3GN7IB8cWEa/oPK5olWjQN8ZI EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywWUGGkCCCJAYdoOtckqSDhs3 ViM9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewckdVAG8fPC/L0DoSL9VdpCE66Jod/MTGSYL y+xkAAygLAajMgu3qq9/Ezajz/EmqUlXjLZ9S2MADv7s1oRiJqNItXxtAOFtaoowJOxFAHpg ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vWkWyKRBaJ9sldrVj Kn74105CHh7ZibCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6xwRd0wPFvY MrBLK5A6Er274w9k1JaoM9Hj9cWKt0WnzuPFfgXMTz6uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp S/Vt44x4AeXuEAr3i3WMiszN+61Bc8XQLBSFXVEAGtEEkMLOO6HxKwea4E2bf8g8ulixuRzV P4LZ4OLBfEnd9gN02V1gUXVxGC6SCmWuA==
- Ironport-hdrordr: A9a23:OeyKsqD4jiviz0PlHeg1sceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYUcegDUdAf0+4TMHf8LqQZfngjOXJvf6 Dsmfav6gDQMkj+Ka+Adww4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq r/Q+BVfYp1P7wrhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+C3Fxy3pDsRKA1
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 11, 2022 at 11:42:05AM +0200, Jan Beulich wrote:
> At their use sites the numeric suffixes are at least odd to read, first
> and foremost for PCI_DEVFN2() where the suffix doesn't even match the
> number of arguments. Make use of count_args() such that a single flavor
> each suffices (leaving aside helper macros, which aren't supposed to be
> used from the outside).
>
> In parse_ppr_log_entry() take the opportunity and drop two local
> variables and convert an assignment to an initializer.
>
> In VT-d code fold a number of bus+devfn comparison pairs into a single
> BDF comparison.
>
> No change to generated code for the vast majority of the adjustments.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Nice.
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
