[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: make "dom0_nodes=" work with credit2
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Tue, 12 Apr 2022 16:17:45 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sWERHgfV9sV13JTJfNMZxFStRVYvJ2bYXVFtyWmir/E=; b=YTbzatTFok7GR5aJNFPFlTfjLcW2AdiKUcyiRFEQMLcabBlLdo4DqdHzv/4lbfyqMGtFArS1DliaW7kXtIlra2iKhEUOFMz/3ElZsCS2sD254y9emiGMka6Vzfue/JItJfxvwejYjEalW9/hxL0n7lVPd7L5ir7SJAiT3oiqvOJP3oT6gdZpjK6q8twWL6k20o+w29GYM2qnCI8Y/Kg/kJTCoTBFCzkio0RtJVEOSBgv+sDpmdGb1AEl1nwxqzYmkvdyi3dsg6ZCdbjZa0gNBoYhu195pFcCGJsyRvddmLrIJOuFlk9S7FWBG4sJjThJSTudjYUrPVvSKzXczLHBAw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1i6+C9WuFsN30dfmLZzyBu09FxnImpOF2EC/UTyaEujtCE2dJz5yoEXPmN6t5/lW9A75ZKKsTfD/ruMoOBoq7t5G1Fy+9EacPOEbR9yLLBsXAQaWa7CF+uv+qyDkVk5BD7kez3fDxSzCgPxP4c4oqer2Ih2ZXAIUge+b8ykx9QbzZJguhyx0Uha+UtwLHVEALLeSN2Wdk7/Ikb72JbLNtlTvsFwlxBbbRm0Q7Op09y3TP8IyJXgchmk5SBtONhKpqbMR16PnDOBrH8RMZ16tHwr1sEY59F7JQ2PdGQhTN/YZBGzP57HjFWWaavAsWlrLJ3y71+mFRGxnnfZqUndSw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "ohering@xxxxxxx" <ohering@xxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 12 Apr 2022 16:17:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYSoM0M4Zi9SzqTkOjTOtQV+PP7azl4C2AgAAVUwCABn7lAIAABpgAgAABqgA=
- Thread-topic: [PATCH] x86: make "dom0_nodes=" work with credit2
On Tue, 2022-04-12 at 16:11 +0000, Dario Faggioli wrote:
> + else if ( is_hardware_domain(d) )
> + {
> + /*
> + * In absence of dom0_vcpus_pin, the hard and soft affinity
> of
> + * domain-0 is controlled by the dom0_nodes parameter. At
> this point
> + * it has been parsed and decoded, and we have the result of
> that
> + * in the dom0_cpus mask.
> + */
> + if ( !dom0_affinity_relaxed )
> + sched_set_affinity(unit, &dom0_cpus, &cpumask_all);
> + else
> + sched_set_affinity(unit, &cpumask_all, &dom0_cpus);
> + }
>
Oh, one thing: AFAICT, it's fine to use, e.g., dom0_affinity_relaxed
(that iis __initdata) here.
But I'm never too sure whenever I touch stuff like that... Is it
actually fine?
If no, I think we can drop the annotation, or add non initdata-
variables.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
|
