[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 13 Apr 2022 07:15:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MKI1JzWv4PwhPpDA4a5jLbM2DVtyJbD9Pn7kdTckDJA=; b=ccF5aH+nA2I2GQgbbBnWgoh37Ls5QnwR919/t3E3zwtCttNkobEGPHg9KsQcSgGM1rjdYXL1EOxXDmQ9kKa79RBQ1HhVAu9DC7g2UAOlVVFu+QJRw6FCLwes2X4J+ykyQvwlUe4IGj2QsQIKmH7I9TGDokfFhb0/rImE/iiUYp4Apohe0FOjjEzKHCv0+By9AMCmb3a3flD1NXVahVcqI42Feb9DWD8b1tF/rkj5GCXHi0O/cGMz3yRe+iM44Q1dV/rcWyNcf0IK3ANk6XAnyc8CS9CA3LBPAPPMYcGjTPDlVCPeifYU4rEaEIXP6QfnOa8Bfggg4jYVc3VXk4MRSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c7QwyhZh4S+mtmHEVJ/9stEd/c3tGuM13e9ksyMvBuL6R/yFCxyqODVhm+eZQ4WhQmB6OOgoV0yrZPiSiwRG56lKcuj4dgRSxMCBuWprR6Q9S5SQj9MDWuo1YvAHJdmIX25rRY45/9FrdjUVEW03+7AORmm2JbUFo30oz5tuR5SG8efp0Y7pMbCNVFBeas9tCTJHilebwQhHzNpuGILh02Zm0M2sQYNKXb/BQU1gITfBWzVeMBWRmw14dtEU9raLZeK2dYsUP6bjXoSYM7k/EbUnbpEYoyEbc0+tTv4G+DNEiVk8hNJGxYWPEZEoPGOI/t3sG+11HgaXH676kY3NwA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 13 Apr 2022 07:16:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYTbfiNTg+IXy/G0GwaoqGDOL0yazq2Y4AgAEwcQCAAAivgIAA2MwAgACFroA=
- Thread-topic: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time
>>
>> No, I'm not suggesting a new menu. I was merely wondering whether the
>> Kconfig contents wouldn't location-wise better match where the
>> respective source file lives.
>
> It could be in xen/common/sched/Kconfig at the beginning of the file
> before creating the new "Schedulers" menu, e.g.:
>
> diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
> index 3d9f9214b8..f6545f4e9b 100644
> --- a/xen/common/sched/Kconfig
> +++ b/xen/common/sched/Kconfig
> @@ -1,3 +1,10 @@
> +config BOOT_TIME_CPUPOOLS
> + bool "Create cpupools at boot time"
> + depends on HAS_DEVICE_TREE
> + help
> + Creates cpupools during boot time and assigns cpus to them. Cpupools
> + options can be specified in the device tree.
> +
> menu "Schedulers"
> visible if EXPERT
>
>
> I think it is fine either way, so:
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thank you Stefano,
Jan for you is it ok at the beginning like Stefano said?
Cheers,
Luca
|
