[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86: annotate entry points with type and size
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 14 Apr 2022 14:59:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5uNq+bMf/0KXclaV12fWHRa6rfIrh4+xcGNYdN0tNk=; b=OVkyLS3M55iyUx49koU7UndC1wdvP2GXiFUlER9Zd2nGdNHsnKD16ADbBh8mqtVjcBvLcO5vASg/E3T1cTIwpZyQZpk9WBGx1WYXwHhMmbRj/3wWFFQfHyZXTPOXnHln33PQ67Vr8GOCDhwyCOuVHiLvaISayNTulFuCzz/FMCG98tmTYho1B/wOZffQ5HylfTeog2w4rI8b2JLr9XOD2b+RAlilluq3mFifhKqszaFVJD6zrqjJrYeN9ImDYcAsFrupNt+kevYEJcU7VdlhJkj/fIEACch4BHxqZr/Y70WCHO+dlj5ERsnySjc/t+HxEg7ErhCFlrdLPrpcnwJp0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gPsagwSQ4JBQJpwMqf0caw2n/zlxDvqmMb8Yotiwcg4V6LM7HaAxG9zHmn+HI0f+QMS8HOHv9RCxmylweS4YJ5lPl7qkx+wJmkD3cvKYvo9VvYl6vuD7feu64Uk7tT1i6T1M1uopGggpdv7HjPRBDGtNQBKs+v5rW76Fm8VgPfCdEeK61YW7cyd2eB4dH0cmECXeZnRWSI7Qxuki1fp33vCjT4XXSbIRlYqbndUJgiJP/wgzahcgC9X4a4lUFgSvJAN7mHnEDb3vUnOslqFd3tKPIptibd0H19OD+cPVz+gzU/zwLiB3+BgyCgffql/UD4zowFphg5OOiargzdhpbg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Apr 2022 12:59:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.04.2022 14:49, Andrew Cooper wrote:
> On 12/04/2022 11:28, Jan Beulich wrote:
>> Future gas versions will generate minimalistic Dwarf debug info for
>> items annotated as functions and having their sizes specified [1].
>> "Borrow" Arm's END() and ENDPROC() to avoid open-coding (and perhaps
>> typo-ing) the respective directives.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> [1]
>> https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
>
> I'm conflicted by this change.
>
> You've clearly changed your mind since you rejected my patch introducing
> this infrastructure and starting to use it.
Hmm, to be honest I don't recall me rejecting such work of yours.
In fact I have always been in favor of properly typing symbols,
where sensible and possible. I would therefore assume it was more
the "how" than the "that" which I wasn't happy with. If you have
a reference to the old thread to hand, I'd be interested in
looking up what made me oppose back at the time.
> Given that it is a reoccurring bug with livepatching which has been in
> need of fixing since 2018, I'd organised some work to port Linux's
> linkage.h as something more likely to have been acceptable.
Taking what they've got would likely be fine as well. At least in
a suitably stripped down manner (looking at their header they may
have gone a little overboard with this).
Jan
|
