[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 27/27] direct-io: remove random prefetches
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
- Date: Fri, 15 Apr 2022 14:08:20 +0900
- Authentication-results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com
- Cc: dm-devel@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
- Delivery-date: Fri, 15 Apr 2022 05:08:43 +0000
- Ironport-sdr: r/U+vtci+X4HPe9ujWMwpfkUfbsbCcWqXKxHoayJa6xV+i8v5i2KJRe1VLg0TixUuTDlh8KxUp xtu7gnPqPhAHBOpyCftZaSWw6kYpv4UNlptcVlimSaiEGocv+DQsQVCE0rd+HVrSWwP+Ch6KLr fRto+V9OoRAsqeiUsp7ZcOOXRLV1l8koA7C0phXDh93tn7qhJtYJ/BN2HJ/00GDqFatPr1iIwb UMOseDrWaxa5Dt0ktXrx4ay9KUVlHM+UiXIQgZgW3pIxDTHMnpEYqWO6/+Iviw7p3MNBB20myA a68RRPf1uCn8s+L/9Ibci2A6
- Ironport-sdr: iL0mm+wiCaUehNzQTIAc5nHSO2tqDZxn1PKkGf9DXqWxstPp2kNwcB7Deo9AkpRy3RSw4yW4PY BOD6EeF/DGebidA6uvD5DpM7isv4WzqSJ8w8F9764sNrbz/HjjFv4964ZZ/GBpOZFrzNUPAeXV 0rfe6BnNHdU2m8txIDi1Le0heuK4ojGJkkzlLD/NADRr8hp81l8bm4CQ8KZMF27OimFMxuEaOP QQOp5d2WGJE3M4c1zAU2bMhrbTxmYZeczUt1U7NjlOtuWa0rx2bl6W91DnlIbxAxGCLEP1xOJ+ veA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Wdcironportexception: Internal
On 4/15/22 13:52, Christoph Hellwig wrote:
> Randomly poking into block device internals for manual prefetches isn't
> exactly a very maintainable thing to do. And none of the performance
> criticil direct I/O implementations still use this library function
s/criticil/critical
> anyway, so just drop it.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good to me.
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
|
