[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dm-devel] [PATCH 05/11] dm-zoned: don't set the discard_alignment queue limit
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
- Date: Mon, 18 Apr 2022 17:00:11 +0900
- Authentication-results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com
- Cc: Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, nbd@xxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Stefan Haberland <sth@xxxxxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Apr 2022 08:00:52 +0000
- Ironport-sdr: TxjYTGZzvwB7psWV6W3KI5gHtngzKvQ9JxaTVaOTeJ4NZK4GDI2cdHKphZ7YJnAEDVEkvrehp/ MAf5al43fZSUKkug6uH5WjF2aCvht2WrBzxmOq7Wgq/TeAKWpiWCP3t5lU1HcAsc378XmzKCi2 qDJiza/Pln0FR8FhC36WJjPliM1zumqCBQSX7G9owKqF+IZ2LG1za0kSZfsUL08F4oOzaglZjJ 86LcQUngZjo7+HI25Jnkx913fesX3QTYhBJ+Oz7g96HU/LzilCpc/PCqii+rycQlaT6HSNc1rF SE+VZcuH4cR8el44w5YJEJUs
- Ironport-sdr: dqA0xkY883fVijO20XJqeYblV2DWNXbc84/nNH4mXZoWrmsCDmq9yK0hYQF03HZX3QBHQEDplf +595UVSkEuhf+7Bi3heEvTHwVRoUxmVPvShU8Ttgw1tcHKIATDvo/BSjz8rJFVXrLrTIykzjJT QsWw7WLn2LBR1V9OdkCICVSyxsYAbFr7P9XukHnxb0pLM72ibiNBafAorxUru7d2Uovq555V+V JnpVEHe6b4S7ggDv9tKgG+ze4OR9H4hkqMHt5h2SIz6gSZreoeiZla8Y4q56rvVpde6bN8fDXb Lk0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Wdcironportexception: Internal
On 4/18/22 13:53, Christoph Hellwig wrote:
> The discard_alignment queue limit is named a bit misleading means the
> offset into the block device at which the discard granularity starts.
> Setting it to the discard granularity as done by dm-zoned is mostly
> harmless but also useless.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/md/dm-zoned-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> index cac295cc8840e..0ec5d8b9b1a4e 100644
> --- a/drivers/md/dm-zoned-target.c
> +++ b/drivers/md/dm-zoned-target.c
> @@ -1001,7 +1001,7 @@ static void dmz_io_hints(struct dm_target *ti, struct
> queue_limits *limits)
> blk_limits_io_min(limits, DMZ_BLOCK_SIZE);
> blk_limits_io_opt(limits, DMZ_BLOCK_SIZE);
>
> - limits->discard_alignment = DMZ_BLOCK_SIZE;
> + limits->discard_alignment = 0;
> limits->discard_granularity = DMZ_BLOCK_SIZE;
> limits->max_discard_sectors = chunk_sectors;
> limits->max_hw_discard_sectors = chunk_sectors
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
|
