[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [dm-devel] [PATCH 08/11] loop: remove a spurious clear of discard_alignment
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
- Date: Mon, 18 Apr 2022 17:04:11 +0900
- Authentication-results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com
- Cc: Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Song Liu <song@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, linux-s390@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, Mike Snitzer <snitzer@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, nbd@xxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Stefan Haberland <sth@xxxxxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Apr 2022 08:04:22 +0000
- Ironport-sdr: bLAYGLCb7s8Y/SCiExQ10X8inQBGQs5XYT3Ch4hjMMOvZfGbMz1IkJa8WKrtmamWpxtYRzw/bI mu4XBidqURZaAz1juycP6OQ6GJNwPndF14rmCvJJpgKI4iUjtynG8NvMZukvwyoGS++cW06oCI R/5ZwY2zPSr8SuDF6RY1pCVQ+D1xgMGVRpryeBt94/nRIN0G4FVTQs2Nm5PPmY3xttT9mHFgfQ R46zKgM93m1qCg5ToeHdQPGR8W3Y37wM3CC/Ouq2vRBpeMzctk+ctTTwCyNQFnZ4OVDJLMiNSh C4X6DbML/BsjVaFyy9W/R8Qc
- Ironport-sdr: lTnMAMxNN/Q0vLxpw8sxmmKrj2CJ2mma0hhAEW+rH9dCGEonA/7O5HV+dTkZu9C0gQGJQyVD+q IaLYmy8sxEOuGoPoT/os/U2nTcOhzF/PJCia/5abgVYlvQWCP1YKoSJyyvcwdJO+USNZtxgIOP VBdXbIEGJHu+CgAbFUudCmEDMPeB6D18eGYG9zwIY1Pcz3bVCwRdqqa89PlyN+IAfLdqRanNcj Td29iafgMgDMFyGLPHMr4GHkHQqcCnTnrJUwSsLXinB7XOF5j6J2UkveYUAHpI9NnuwUo0VnOi FrU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Wdcironportexception: Internal
On 4/18/22 13:53, Christoph Hellwig wrote:
> The loop driver never sets a discard_alignment, so it also doens't need
> to clear it to zero.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/block/loop.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 976cf987b3920..61b642b966a08 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -789,7 +789,6 @@ static void loop_config_discard(struct loop_device *lo)
> blk_queue_max_discard_sectors(q, 0);
> blk_queue_max_write_zeroes_sectors(q, 0);
> }
> - q->limits.discard_alignment = 0;
> }
>
> struct loop_worker {
Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
--
Damien Le Moal
Western Digital Research
|
