[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2 0/6] populate/unpopulate memory when domain on static


  • To: Penny Zheng <Penny.Zheng@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 19 Apr 2022 10:46:36 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u7PxaHUOrgYXxz8Eg25NMAmP24bRqiAmVQlVEwg2qVk=; b=KZEmQqvhcH/ND0/eDGegIKFrGIX74wWDEj5druJvv9VlcisIGxjv91KGHglZKg/0YeYIqgA13oO+gGTffTAAxJR5GKjSSSx8ciuqDl71HylJ9oByNmYYawFs3MfFCjfl+kL/dsoXn3uWJWZppCGMn94LQkc2bhMS8hCSSwKxJtNDAjxO13dB5IdM03rrnVyBA1RQNleobff7YaYGxJOQdJTxv2OJoYa3z465YFQoMB2syOJjOhUp6iBKOPLKKpKGroOWGUno3DS38Wd7jz2zQzaiBRGgODKdFZoekSF25ACRfiGWsUulwDQ8699GYj/kUxt7Mo1bw/oP1FtElcl0KA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4gk/5AjEc6xmnf/TsAhPlNUhanmqu+Kh8HKZbJjdMBJTE+YtMIK90ls312f6OSU25qR5RuV/k2oddHo8c2YwylMSKG99ase/tZO/JDjHmkrdpQohski5YziJmR7FOm8HxGxrik6xi5LlRYBOKT6heo0icd8Cylvhscj1+AcRcx4eELTLxOtrHdveNAov92xRMfrgppW9jfUqevqa7s5auf8ZuMkGat5jA48VtK6bg3ACjMDodkKYrRyPbouNuDSjLxcMVcG4ktrXvD2XxYMPKXZsK0crbOhjUN8rK+/r1zydXLza9TGwXE2xGJ2ZHiVZ3bh4/cWkG6x68KBvXKsgA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 19 Apr 2022 08:46:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.04.2022 14:22, Penny Zheng wrote:
> Today when a domain unpopulates the memory on runtime, they will always
> hand the memory over to the heap allocator. And it will be a problem if it
> is a static domain. Pages as guest RAM for static domain shall always be
> reserved to only this domain and not be used for any other purposes, so
> they shall never go back to heap allocator.
> 
> This patch serie intends to fix this issue, by adding pages on the new list
> resv_page_list after having taken them off the "normal" list, when 
> unpopulating
> memory, and retrieving pages from resv page list(resv_page_list) when
> populating memory.
> 
> ---
> v2 changes:
> - let "flags" live in the struct domain. So other arch can take
> advantage of it in the future
> - change name from "is_domain_on_static_allocation" to "is_domain_static()"

I have reservations against this new name: This could mean far more aspects
of the domain are static than just its memory assignment. Was this intended
(or at least considered)?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.