[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] xen: add field "flags" to cover all internal CDF_XXX
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Apr 2022 11:02:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jt0RknuV99Mj9cCd8QTaNFDAERTxKaglg8gBpbdXbLg=; b=nI2rHQF7Y8qCJPmbTJpTx2Y20M6saKwabmT3+Vf6LyiW3ld1wwKpBW9WGG7bQruw70J7fY53kkhHgEKW+NBMlY/GIuFWOa+1sVRxIYXO1IVqUOYNtllPh95jjNSLBedI3iNtAxtkilHRdIHsX5TRb16WgJgDfm0o4wq8fqjRMB0k/3Ii8/oUJ5Y7Sidh90ppMk7WA9HduE0nL9psNOBTRa5B+TCRijBS0YgfbHElMwTuqEL+ywY8kKYlOopGNJEuCWNZVgrtTd5Khj+/2G1YQzqa+a2Wn1nrnCspP5YSqngtK2W/w0r2FUqmVfTLG1LFvHzFneTUGsuQsMU0a1AHgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DFPKad2H9bmWgsH8IjxEhrStB47Ag8U4ouOL5ByWwBdcqyVxhI0/fwMC1f5QeY+KE8O70P6UqhZ1cRtVukjve+cl2Rnbz57g6xbzUDzSA3aJluE06VS+kRMMkWrl5CVnjkABQLp6blRcIpCTT1S9lTJFO/px7McO2XYipYQa+qick0ZJI/TxkFNs+1BfpYMXW8K1ziY3NJWR4QoQUo5+mbAnwnh29LKbS5zq3Gg5x0ARngoosFMIBRt4Bw2nrHnZ36UudZk7YNRptZyiUpdu8vqAmKJIV9hzWnUX0I9SKhu7tvQD3yf6qpDZfaBzZTIo0d9BjmDZ3JMM/qXnPISFHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Apr 2022 09:02:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.04.2022 14:22, Penny Zheng wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -591,6 +591,9 @@ struct domain
> struct ioreq_server *server[MAX_NR_IOREQ_SERVERS];
> } ioreq_server;
> #endif
> +
> + /* Holding CDF_* constant. Internal flags for domain creation. */
> + uint32_t flags;
There's no need to use a fixed width type here; unsigned int will do.
See ./CODING_STYLE.
I'd also like to ask for the field to be given a more descriptive name.
Just "flags" can mean about anything. Maybe simply "cdf"?
Jan
|
