[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: fix XEN_DOMCTL_gdbsx_guestmemio crash
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Apr 2022 11:25:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s4SRGsT3WsC/afQ7S+TOAetnWSUu5B4GZ271bnn/29A=; b=j7ciDeGr/eGb6v+lUlcH2ES55IIVLETh9R8TBwULBldvrROkNhiGGwClV1eoyklw9I23fYT8RkUdqx/oNChtztmbe16Ti8cQsYBgX6wwm4xtA46Qqt6l49ranaTwnBPCzvkdo5a3Uic69W01GLinFmmNgWQET5kfxSTVwrP19d8H79WvOJc3+LOTMCn2WthMDcMFXfJq9cMGIY44wtR6m37pyzLPb3X1J5tRgNh9c7ClAVzT4FAAKKMV6/5lV5Mz2s+MaSmbUcYyvrnRULU9LGf0rN4/s2ch+QKiKo+smTVdLFISQEe49N3ta2es+ERex7yMeELH7bCtiEy0oEWwDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/acbrCzJx9zkn3c/v9axoi0a9m9EWgdpVAljXsbw8CdLZxEqi3cvQl/D+Udph0ksKfQNImTmHSxzkiYEKjw9kpsKaXC7vEq+u8yVNf3dFS2iffKs2lFcBJ7ILq+NPkfCey2KFOdNwQT0w2cq9nC0i+vhKKzi7zaehQEeqTsoZtQehaD3n6h94RIJciLlkPf/ALC5deIUsd5ULb9LqMgwdyH5E1bNumO3wOsxqAygefa/EXf8tD9kOJVqD8MksLYANWpnV3TnQ9oXlzWmB1joLkQGaFmHZLFwhAP+vPBxUYhlbcPOFiPWKUeyXBfdhQ4iiX4zw629PGcUzuGuZQ88Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Cheyenne Wills <cheyenne.wills@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Apr 2022 09:25:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.04.2022 11:22, Juergen Gross wrote:
> On 19.04.22 10:42, Jan Beulich wrote:
>> On 16.04.2022 15:31, Juergen Gross wrote:
>> And finally I think iommu_do_domctl() needs making resilient against d
>> coming in as NULL. This isn't just to cover the issue here, but perhaps
>> more importantly because XEN_DOMCTL_test_assign_device can legitimately
>> end up having NULL passed here (when the caller passed DOMID_INVALID).
>> We've simply been lucky that libxl doesn't use this variant of calling
>> this domctl. I guess when d is NULL we ought to check the global flag
>> there rather than the per-domain one.
>
> I think this should be another patch, though.
Sure. I'm happy to make one.
Jan
|
