[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
- To: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 19 Apr 2022 11:42:12 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qcSjmxtDOAjsYOSIkWfBt4XvmdTtGb2BWbNkcowgQ6o=; b=SFnpoIgApVF5roWbU7QLexA5/dhlkJoeyO/Kr6p2xFr80bxrk5du9UNBy1/THHhCyU0bHV/cG1Pj0qdwee3tgGzfvZ3P1mcMkFFcNFjKC4bUlIOrUFIb8MKBjsai5NAT7RJsGeXZ4vyeuICrB5XP1cN7zR0MYbVD1l2fa0sndQyjyZ5LcmDfKfAOvy9w687JuF7HqIn81ZkFUDfAVgY3+9j9p0WcNeFFSSLYk8O63Cj5UogIdHq+uMS5WYmTQOmF7hs2dLk/ridznun3OanEnieDZxn/eciaLNTjmuDP9Hpqtmq+haebgGgH6GO6SMf6mAQOuYc6vKOdtL21wqeMSw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HkMD9vSZPzzp7S6b41xgGUKBloVIn19S88uk2DAMk7Jm5sMYClpVSqbeWGsTnLNMR38QBf0CJQPtob+D1y/YwRLeDvyNDxX6s/0ezAYhN7/bhIuIrzL0l6UaCHpbsKxRKHIXy6kMkYMgcXjjl+tG//KAVnkJTTUm0oItYGOJ/XZ80Nelpn+70l5npBHTH3iVxdv1y2WyQN5Zdb12r4bC1GiA5iByccEiJtp02qtI+XHfJMfczq8gfneCumxuostUvsIuHNRaXMGDRXvRdRieRid7dJvQeOs2mDgWuqbnDiecp9cpysx1AzKmYOCbPH9kYnxl9jRxyhS/gk/Tt+aSvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Miroslav Benes <mbenes@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Apr 2022 11:42:31 +0000
- Ironport-data: A9a23:Pdt3LavPAf7MRJHJ4Ayf1sz+FefnVNZfMUV32f8akzHdYApBsoF/q tZmKW6DPqzcM2v9fdhzady1pElSupTdmtMySFdv+Ho0FClE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQyw4bVvqYy2YLjW1/U6 IuryyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi80A6vioLUjSCN2LBB0Oaoa3ZbYK1uW5Jn7I03uKxMAwt1IJWRvZcgy3LkyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AAmm5o36iiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvTmInV0ugeSF3Nz9IvmPR/13uXmhu 0XJ/j3kJCkBEN7E8G/Qmp6rrqqV9c/hY6oQDLq58/RtjXWJy2ATAQFQXly+ydGp2hCWWN9FL UEQvC00osAa7EG3Q8Pvdxy+rmSNshMVV5xXCeJSwAWMzLfEpgWUHG4JShZfZ9E88sw7Xzon0 hmOhdyBLTllvbuYUlqG66yZ6zigUQAfKnUDfmkDVhcf5Mf4o5AbiQjGRdJuVqWyi7XdGz7qx CuRhDMjnLhVhskOv42g5kzOiT+oopnPTyY26x/RU2bj6Rl2DKa1aort5VXF4PJoKIeCUkLHr HUCg9KZ7u0FEdeKjiPlfQkWNLSg5vLAOjuDh1dqRsEl7270oyflep1M6jZjIksvKtwDZTLif E7Uv0VW+YNXO3ypK6RwZupdFvgX8EQpLvy9Pti8UzaESsEZmNOvlM22WXOt4g==
- Ironport-hdrordr: A9a23:4lXt6aniA7N8LDFeHrddo+S9nV/pDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWUzxjIiLH47JlOy1GnnKp gdMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe q1NdZfH+LjRFGebLp04w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYU0SHTqWJMApeME+vJqcoJU7NiKz3HnsA
- Thread-topic: [PATCH v2 06/25] x86/xen: Add ANNOTATE_ENDBR to startup_xen()
On 18/04/2022 17:50, Josh Poimboeuf wrote:
> The startup_xen() kernel entry point is referenced by the ".note.Xen"
> section, but is presumably not indirect-branched to.
It's the real entrypoint of the VM. It's "got to" by setting %rip
during vcpu setup.
We could in principle support starting a PV VM with CET active, but that
sounds like an enormous quantity of effort for very little gain. CET
for Xen PV requires paravirt anyway (because the kernel runs in CPL!=0)
so decisions like this can wait until someone feels like doing the work.
> Add ANNOTATE_ENDBR
> to silence future objtool warnings.
>
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
FWIW, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, preferably
with the commit message tweaked to remove the uncertainty.
~Andrew
|
