[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 20 Apr 2022 05:20:32 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sCRvPT5tGqVtiSgddC/uOQHw4vYXTqMXlCZj29+Cv04=; b=Hkib1xfTbd9261fos459RRLDUjXO46VarsUUtDQo/V9/o3KlFrQZfkMMsStDenVl5s613q+fw6xjMntHTBw0IJLxcfgHA0+Hz30FkiLBrKs/MQHGwWCQg3XoqjTEzbTjr3/sDOZjWeTsiMJsZ2E3l6LIXM0PMD+CU52ZVJgmAqfl6gkEkCWsrvBAC81NQ10dJNawgNbpGDVMMbL+ycZUGOJkeW0/cM9SBcx5njC3vIsjBDrZvPtHzj2x08m4p6TwllEbTapdyRWLeNcXCm13BDcsCPjfh2lEbU1IZaQ4ahnMoUjkks+G69Kio9SSVjy1mjxhVDrj2ldfUX75TGhatw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8854Oz1L/P0mFyLo46uFTq89q/oYz2T2OelvxOOVQrDastDabJ8MHiPRLxcBGzCK1rkH4gomFFl3coikjLQUc8ijPGUaBDaM6A4T+p+T8yrRGniW12ocTRxRtXZm5DAf2mw4oe/7p9F+1oeoTIbFNJWDImL0mFs7XjzRQQpYSi3RdBWEzEkNYBNnRfzq7Vs+goo78JjxtZ7XuBY1nu37/H+Qi5dMKmf7AO5PswTjIJGAC6PTQA+3lv3V92JaJ+pCEplgOR5Ok65oYVYLtm2M+O/gclIP67TiaUwHwESxvpG/CNMKiNgzBDJEYIekLCG1jr1ma+D6/+88+A1gE5ymA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <Julien.Grall@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jiamei Xie <Jiamei.Xie@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 05:21:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYS3WQHsQlT+jCYUK0AMl/K/Wipqz4VTPg
- Thread-topic: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
Hi Oleksandr,
> -----Original Message-----
> From: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
> Subject: [PATCH V7 2/2] libxl: Introduce basic virtio-mmio support on Arm
>
> From: Julien Grall <julien.grall@xxxxxxx>
>
> This patch introduces helpers to allocate Virtio MMIO params
> (IRQ and memory region) and create specific device node in
> the Guest device-tree with allocated params. In order to deal
> with multiple Virtio devices, reserve corresponding ranges.
> For now, we reserve 1MB for memory regions and 10 SPIs.
>
> As these helpers should be used for every Virtio device attached
> to the Guest, call them for Virtio disk(s).
>
> Please note, with statically allocated Virtio IRQs there is
> a risk of a clash with a physical IRQs of passthrough devices.
> For the first version, it's fine, but we should consider allocating
> the Virtio IRQs automatically. Thankfully, we know in advance which
> IRQs will be used for passthrough to be able to choose non-clashed
> ones.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Tested-by: Jiamei Xie <Jiamei.xie@xxxxxxx>
> Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
> ---
> @Jiamei, @Henry I decided to leave your T-b and R-b tags with the minor
> change I made, are you still happy with that?
Sorry for the late response, just checked the code and yes I am happy with
keeping my Reviewed-by. Thanks for your effort in rebasing the patch!
Kind regards,
Henry
|
