[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
- To: "Beulich, Jan" <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Wed, 20 Apr 2022 06:22:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=03xnvSEgeZc2kLEIH/lD3I3fUQvE0976IRBRbE2YKPI=; b=mvPTlOoywlI+01R26Ms3qYv6RCXihWG9I3H7UtI4uP40ee8+i9BlwmhLarQCtObaAF6fUENAdZRGn7ZVOUbnzAYdF0ZQM2BCcbIf+DC2YsKx9+hpDL5sHuhsfxoFauJBpr2iIVIyVIGgiTO8HDenUfFNfnAq2uZ8sLkXdYvwMNLMjt/Sr6UYxRt2rQmhxiu5FM6Ywc1HsD8q3ZLv301p1mBXDcbt7WirgipP6LlrO2v+52K0rMfm7bHAKrUf2Xap1YiCN//5++Zc3FY6bgwCW5A6r8OYrr0QG71EhYYEQBGzEJCmCgSbR7fdrXrDIYEysK9Kx6ibOZrKu1cE1igGYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YMEcQ1xs0zWy4Y6fCf08AZzGHKo+UYD2jKCe0AM+0tx38XTZ8GycGnOS/Lml3yRjILryyaJVI5fOgUYj97CsAKrrPbu9D2BV4Za+VlJQne1kgcbUjF9l1MHs6HFV/CuvlPikRh9/gGgJAIFN4UDq/fqdqT+ViWLebMGpIyqao8ovmPd6IYbdlYKgChKXcNHP57S9Uy1pCCnW9tMhPqVy+u5SrCnUF+Jj2Kiu14VYSibKXK3iIDU77ozNiOca9967WnYQIB7LJg9KOiO7YJQ+WSDyI+11p0VkIJ1B/2jkwMNEmZ73FS25LkUgqJJH+9VTu9knhIteCWJT8Hb6XV3+jQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 06:22:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYTYekX5EMpeqzC0Kga/gFrdxJaaz4XMTg
- Thread-topic: [PATCH 2/8] VT-d: drop ROOT_ENTRY_NR
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, April 11, 2022 5:36 PM
>
> It's not only misplaced, but entirely unused.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> --- a/xen/drivers/passthrough/vtd/iommu.h
> +++ b/xen/drivers/passthrough/vtd/iommu.h
> @@ -204,7 +204,6 @@ struct context_entry {
> __uint128_t full;
> };
> };
> -#define ROOT_ENTRY_NR (PAGE_SIZE_4K/sizeof(struct root_entry))
> #define context_present(c) ((c).lo & 1)
> #define context_fault_disable(c) (((c).lo >> 1) & 1)
> #define context_translation_type(c) (((c).lo >> 2) & 3)
|