[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "Lengyel, Tamas" <tamas.lengyel@xxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Wed, 20 Apr 2022 06:39:50 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7rBLHHrGkg/4TvPuK3RUJQbKvkw3gMsspWiitP1t69c=; b=XU6Ja0atnHnYU9FaXUuN+wmY/swxH7FwOdxa9HAENy+QOQcVVeKgWG5Duv8KK+5IfU9op0+f0+pXyOlBOxDS9mhaF83DAhQqY86hbTeC+Xnn3GdMujysfOIOES977l6JHGXSGcRpxOAaqpiQC7he47+hUD/eJTujgeW012PKTz3U3dTM09vwPp48KuMOfaHI74hY0n/CezrMpXHqmnTWrMr+mxXZ/aE27rPAo3XTKED7CSJzkdXfTjnRkO6emj1epGzAbj7IgYzosrQ7r8fV/iynNImlCNyitQXK2WV4VIsntu2QL/cWjItaJ6Lbbozny51HnCGp1SgImJvO7qyNbw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ADuumaRQXH0P66mVaCPMB7jiWjFxA6ugIRZ8ny9iSpr7eBAk+uwgT9PQxKKSMF96qqHHz6sEyyQ2DSFdzPmmsx+4VMv8A/U/OTDe3VNnJuDfG4AiPkzSKevjPmOdV+GjuQ9TwffvO+NGK16yu6aB120DkChk9D39VPaywUz6Kp1udY+RorH2YnFhqm9x79Xqo618Xo/mnlhbpTsEH9L8vr5YP8lLjPKanR93bXRgkEG7OyGZhCIEqs7whsNHanDwZ3TxQyfec2c3ZvCVcRXH+MVxdAPfvKQa+I76lyRQs0d0CKA1fLZmxAmnqML1/AVi8qHoy7w0/ly5pUjxYYgF0w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Beulich, Jan" <JBeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 06:40:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYQE0JDO4TZ1lTNEeFxdnKer9Q96z2J8gAgAJaNrA=
- Thread-topic: [PATCH v5] x86/vmx: add hvm functions to get/set non-register state
> From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> Sent: Tuesday, April 19, 2022 2:43 AM
>
> On Fri, Mar 25, 2022 at 9:34 AM Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
> wrote:
> >
> > During VM forking and resetting a failed vmentry has been observed due
> > to the guest non-register state going out-of-sync with the guest register
> > state. For example, a VM fork reset right after a STI instruction can
> > trigger
> > the failed entry. This is due to the guest non-register state not being
> > saved
> > from the parent VM, thus the reset operation only copies the register state.
> >
> > Fix this by adding a new pair of hvm functions to get/set the guest
> > non-register state so that the overall vCPU state remains in sync.
> >
> > Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>
> > ---
> > v5: Switch to internal-only hvm funcs instead of adding to hvm_hw_cpu
>
> Patch ping.
I'd like to hear opinions from Andrew/Jan first. Obviously they have
different thoughts when reviewing the earlier versions.
|
