[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] x86/build: Clean up boot/Makefile
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 20 Apr 2022 14:07:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/wn6ejJNHIEeQONgUARuPPeuAi929+fhMrD6sGHKZc=; b=AyCAD9B31W2b1WgXUNyXpBuoF3pQYfs+Dae5/ZfSUGf+1eTCy88fOyfoENDFFTBwx6R8pPoExprki0cbD83Ua1lRJVh0kugGanak85nm+RHuBjMaVlgi9XfEAkaVlHNYxJZUfbu1zr/H6ENFE9risYb6OH87pG6d2Zbw2zmD4Omu88vqxJVdEHRDdIaoRM6SE/yatWjkUyirmAgJykO+QMkGAIMl0QZuS79mlAjVdn2I5d5Qw+3rgs2vhT/o+1DREFeQVwKtwrRHIo3jUnmhsaL/QPHcY78Frg+PazJSVCw4NKznU7zXne5dNbgrBHnka4Ri05RSMpaFSovidFzK6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O21eGBGUfmO10XhCWKH/98fSe3C1GBxcgrmdK54GhRo2oWl3IYmz28svUc0toeRQfi3rhJENcvqMWiPKBfXMXlRkW4iGg3d2kGuAIb5p/iiVLuosG2PLiylW26YxIyw6Os4Zqz6yK35/s1mNXEa3s9RT5zEv6M1PDzh8XNFJwxAnWmvZUVbwYDZ8KAC/sGYyYJdKBHBbsePCB1KESUlE8+7kD2Q0fiZJboIQZ/gC8062O6ddXm+uiBMMYTItJG4KJ25ofFutbDOALtvX/EalIVylM1y6Oa/PgI+GS04K39tQsmin4nmYT65IeceKLRwKmVjnoFBERPlTsnZIV0juig==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 12:08:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.04.2022 13:47, Andrew Cooper wrote:
> There are no .S intermediate files, so rework in terms of head-bin-objs.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> I'm slightly -1 on this, because
>
> head-bin-objs := $(addprefix $(obj)/,$(head-bin-objs))
>
> is substantial obfuscation which I'd prefer to bin.
Would ...
> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,16 +1,17 @@
> obj-bin-y += head.o
> -head-srcs := cmdline.S reloc.S
>
> -nocov-y += $(head-srcs:.S=.o)
> -noubsan-y += $(head-srcs:.S=.o)
> -targets += $(head-srcs:.S=.o)
> +head-bin-objs := cmdline.o reloc.o
head-bin-objs := $(obj)/cmdline.o $(obj)/reloc.o
> -head-srcs := $(addprefix $(obj)/, $(head-srcs))
> +nocov-y += $(head-bin-objs)
> +noubsan-y += $(head-bin-objs)
> +targets += $(head-bin-objs)
nocov-y += $(notdir $(head-bin-objs))
etc perhaps be a little less obfuscation?
Jan
|
